Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Google Ads: add new stream Campaign Budget #28078

Merged
merged 5 commits into from Jul 10, 2023

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Jul 10, 2023

What

Resolving:

How

  • added a new stream to the list of streams
  • added the stream class CampaignBudget
  • the added schema for the new stream
  • added expected records for the new stream

NOTES:

The following SEGMENTS are not included in the stream:

  • "segments.conversion_action"
  • "segments.conversion_action_category"
  • "segments.conversion_action_name"
  • "segments.external_conversion_source"

since they have conflicts with certain AVG aggregated METRICS like:

  • "metrics.all_conversions_from_interactions_rate"
  • "metrics.average_*" (all kinds)
  • "metrics.conversions_from_interactions_rate"
  • and many more

They could be fetched without avg aggregated metrics (the general metrics only)

🚨 User Impact 🚨

No impact is expected - not a breaking change

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@bazarnov bazarnov linked an issue Jul 10, 2023 that may be closed by this pull request
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 10, 2023
@bazarnov bazarnov marked this pull request as ready for review July 10, 2023 12:46
@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit 1bcfae1cd2) - ✅

⏲️ Total pipeline duration: 18mn36s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit 233cc88d36) - ✅

⏲️ Total pipeline duration: 15mn10s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@bazarnov bazarnov merged commit a47fcf1 into master Jul 10, 2023
22 checks passed
@bazarnov bazarnov deleted the baz/source-google-ads-new-stream-campaign-budget branch July 10, 2023 16:50
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Google Ads: new stream Campaign Budget
3 participants