Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Analytics (UA): specify date format in spec #28149

Merged
merged 7 commits into from Jul 19, 2023
Merged

Source Google Analytics (UA): specify date format in spec #28149

merged 7 commits into from Jul 19, 2023

Conversation

arsenlosenko
Copy link
Contributor

@arsenlosenko arsenlosenko commented Jul 11, 2023 •
edited

What

Resolve issue described here:
https://github.com/airbytehq/oncall/issues/2034
Right now user can enter almost any value for start_date during connector setup, added format to spec so only dates could be accepted

How

Updated spec, added format entry to enable datepicker in UI. Also updated pattern in spec to make these changes backwards compatible and pass CAT test which generates different fake configs.

@arsenlosenko arsenlosenko self-assigned this Jul 11, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-v4 labels Jul 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited by arsenlosenko

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@arsenlosenko arsenlosenko marked this pull request as ready for review July 11, 2023 11:35
@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-v4 test report (commit 3b8f9cd4b1) - ✅

⏲️ Total pipeline duration: 24mn08s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-v4/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-google-analytics-v4 docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-v4 test

@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-v4 test report (commit 3b8f9cd4b1) - ❌

⏲️ Total pipeline duration: 06mn27s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-v4/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-google-analytics-v4 docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-v4 test

@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-v4 test report (commit d61e4f8c58) - ✅

⏲️ Total pipeline duration: 25mn07s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-v4/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-google-analytics-v4 docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-v4 test

@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-v4 test report (commit d7cc3b1d82) - ✅

⏲️ Total pipeline duration: 28mn58s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-v4/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-google-analytics-v4 docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-v4 test

@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-v4 test report (commit 37a9c3efa3) - ❌

⏲️ Total pipeline duration: 34mn40s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-v4/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-google-analytics-v4 docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-v4 test

@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-v4 test report (commit ccbf9a4f75) - ✅

⏲️ Total pipeline duration: 33mn46s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-v4/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-google-analytics-v4 docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-v4 test

@octavia-squidington-iii
Copy link
Collaborator

source-google-analytics-v4 test report (commit 1a1182b552) - ✅

⏲️ Total pipeline duration: 21mn31s

Step Result
Validate airbyte-integrations/connectors/source-google-analytics-v4/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-google-analytics-v4 docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-v4 test

@arsenlosenko arsenlosenko merged commit 88ce714 into master Jul 19, 2023
24 checks passed
@arsenlosenko arsenlosenko deleted the arsenlosenko/source-google-analytics-v4-format-date-spec branch July 19, 2023 18:59
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@arsenlosenko @efimmatytsin
Source Google Analytics (UA): specify date format in spec (airbytehq#…
cafd9a3 
…28149)

* Source Google Analytics (Universal Analytics): specify date format in spec

* Update changelog

* Specify pattern in spec to pass CAT

* Update spec to support previous date format

* Leave validation only for YYYY-MM-DD dates, as the only valid option
@arsenlosenko arsenlosenko mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees

@arsenlosenko arsenlosenko

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arsenlosenko @octavia-squidington-iii @lazebnyi