Source Amazon Ads: fix Nonetype error when recordId is missing

[roman-yermilov-gl]

What

• https://github.com/airbytehq/oncall/issues/2413

How

Bugfix: conditional expression was constructed wrong way

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• The connector tests are passing in CI
• You've updated the connector's metadata.yaml file (new!)
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[octavia-squidington-iii]

source-amazon-ads test report (commit f8aad94d2d) - ✅

⏲️ Total pipeline duration: 02mn56s

Step	Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

[erohmensing]

@roman-yermilov-gl thank you! is there a good way to unit test this change?

[lazebnyi]

LGTM! After adding unit test can be merged.

[roman-yermilov-gl]

@roman-yermilov-gl thank you! is there a good way to unit test this change?

Made a refactoring and a unit test

[octavia-squidington-iii]

source-amazon-ads test report (commit d8eabbf51c) - ✅

⏲️ Total pipeline duration: 03mn24s

Step	Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

[octavia-squidington-iii]

source-amazon-ads test report (commit d8eabbf51c) - ✅

⏲️ Total pipeline duration: 03mn14s

Step	Result
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test