Fix JDBC Test.

[davinchia]

What

Fix JDBC test.

How

• Remove supported_destination_sync_modes from the jdbc spec.json.
• Add condition to test - only test dedup if a destination implements basic normalization.

Pre-merge Checklist

• Run integration tests

Recommended reading order

Two small files.

[davinchia]

@ChristopheDuong stumbled upon this while implementing my namespace change. I think this is right based on my understanding - need normalisation in order to dedup so the append dedup test shouldn't run for connectors that don't support basic normalization. does this make sense?

[davinchia]

/test connector=destination-jdbc

🕑 destination-jdbc https://github.com/airbytehq/airbyte/actions/runs/732016972
✅ destination-jdbc https://github.com/airbytehq/airbyte/actions/runs/732016972

[ChristopheDuong]

Today the way the append_dedup is implemented is only in the normalization code so yes you are right they are both required.

But we could have a connector that decides to implement append_dedup (in meilisearch for example by upserting into indexes instead of appending?) without ever implementing normalization...

So maybe the better fix here is to remove the append_dedup option from the JDBC destination supported_destination_sync_modes, you can leave the 'append' and 'overwrite' ones though.

But still, maybe we should keep your addition for testing support of the basic normalization because of the way the test is implemented which are very tied to normalization implementation of dedup.

[davinchia]

/test connector=destination-jdbc

🕑 destination-jdbc https://github.com/airbytehq/airbyte/actions/runs/732578400
✅ destination-jdbc https://github.com/airbytehq/airbyte/actions/runs/732578400

[davinchia]

Made the changes @ChristopheDuong ! How does this look?