Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Twilio: update expected records #28216

Merged

Conversation

arsenlosenko
Copy link
Contributor

@arsenlosenko arsenlosenko commented Jul 12, 2023

What

Fix failed CAT run for Source Twilio

How

  • Add property channel_metadata to schema of conversation_messages stream
  • Update expected records for stream conversation_messages

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-twilio test report (commit 6d61382415) - ✅

⏲️ Total pipeline duration: 55mn42s

Step Result
Validate airbyte-integrations/connectors/source-twilio/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-twilio docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-twilio test

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 12, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-twilio test report (commit b9f8c4fdac) - ✅

⏲️ Total pipeline duration: 57mn48s

Step Result
Validate airbyte-integrations/connectors/source-twilio/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-twilio docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-twilio test

@arsenlosenko arsenlosenko merged commit ead6bcf into master Jul 12, 2023
26 checks passed
@arsenlosenko arsenlosenko deleted the arsenlosenko/source-twilio-fix-expected-records-07-12 branch July 12, 2023 16:27
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
* Source Twilio: update expected records

* Add channel_metadata property to stream conversation_messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants