Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ ✨ Source Google Ads: add new streams #28246

Merged
merged 72 commits into from Jul 13, 2023

Conversation

davydov-d
Copy link
Collaborator

What

#27477

How

Add new streams:

  • Labels
  • Account Labels
  • Campaign Bidding Strategy
  • Ad Group Bidding Strategy
  • Ad Group Criterion
  • Ad Group Criterion Label
  • Ad Listing Group Criterion

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads labels Jul 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@davydov-d davydov-d marked this pull request as ready for review July 12, 2023 18:56
@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit 0dac564772) - ❌

⏲️ Total pipeline duration: 16mn56s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit 27fc347269) - ❌

⏲️ Total pipeline duration: 16mn09s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit 1fb032ddf1) - ❌

⏲️ Total pipeline duration: 16mn43s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@octavia-squidington-iii
Copy link
Collaborator

source-google-ads test report (commit 6e31aa48a8) - ✅

⏲️ Total pipeline duration: 16mn10s

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-google-ads docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

@davydov-d davydov-d requested a review from a team July 13, 2023 10:19
@lazebnyi lazebnyi removed the request for review from a team July 13, 2023 12:56
@davydov-d davydov-d merged commit c816d14 into master Jul 13, 2023
23 of 25 checks passed
@davydov-d davydov-d deleted the ddavydov/#27477-source-google-ads-new-streams branch July 13, 2023 13:53
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* add new streams

* upd changelog

* update CAT config

* update expected records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants