Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSV options to the CSV parser #28491

Merged
merged 73 commits into from Aug 3, 2023
Merged

Add CSV options to the CSV parser #28491

merged 73 commits into from Aug 3, 2023
+1,533 −130

Commits on Jul 19, 2023

  1. remove invalid legacy option

    @girarda
    girarda committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    f744e2c View commit details
    Browse the repository at this point in the history

  2. remove unused option

    @girarda
    girarda committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    fb5a57d View commit details
    Browse the repository at this point in the history

  3. the tests pass but this is quite messy

    @girarda
    girarda committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    3230205 View commit details
    Browse the repository at this point in the history

  4. very slight clean up

    @girarda
    girarda committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    f6a67db View commit details
    Browse the repository at this point in the history

  5. Add skip options to csv format

    @girarda
    girarda committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    d01200b View commit details
    Browse the repository at this point in the history

  6. fix some of the typing issues

    @girarda
    girarda committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    b271a9e View commit details
    Browse the repository at this point in the history

  7. fixme comment

    @girarda
    girarda committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    7add1c7 View commit details
    Browse the repository at this point in the history

  8. remove extra log message

    @girarda
    girarda committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    e8c88be View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. fix typing issues

    @girarda
    girarda committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9e73b51 View commit details
    Browse the repository at this point in the history

  2. merge

    @girarda
    girarda committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    84cabeb View commit details
    Browse the repository at this point in the history

  3. skip before header

    @girarda
    girarda committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    79f7748 View commit details
    Browse the repository at this point in the history

  4. skip after header

    @girarda
    girarda committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0ae95da View commit details
    Browse the repository at this point in the history

  5. format

    @girarda
    girarda committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6324257 View commit details
    Browse the repository at this point in the history

  6. add another test

    @girarda
    girarda committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0fd42ca View commit details
    Browse the repository at this point in the history

  7. Automated Commit - Formatting Changes

    @girarda @octavia-squidington-iii
    girarda authored and octavia-squidington-iii committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    8b54aff View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. auto generate column names

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b9a4a71 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'alex/csv_options' of github.com:airbytehq/airbyte into … 

    …alex/csv_options
    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9982834 View commit details
    Browse the repository at this point in the history

  3. delete dead code

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    32844ce View commit details
    Browse the repository at this point in the history

  4. update title and description

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    cd48738 View commit details
    Browse the repository at this point in the history

  5. true and false values

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    43ce434 View commit details
    Browse the repository at this point in the history

  6. Update the tests

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    df47586 View commit details
    Browse the repository at this point in the history

  7. Add comment

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ce9a672 View commit details
    Browse the repository at this point in the history

  8. missing test

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2c03349 View commit details
    Browse the repository at this point in the history

  9. rename

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c445b02 View commit details
    Browse the repository at this point in the history

  10. update expected spec

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ff8f5d4 View commit details
    Browse the repository at this point in the history

  11. move to method

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    87a3bcb View commit details
    Browse the repository at this point in the history

  12. Update comment

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9a1954f View commit details
    Browse the repository at this point in the history

  13. fix typo

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    72caf7d View commit details
    Browse the repository at this point in the history

  14. remove unused import

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ecea4e0 View commit details
    Browse the repository at this point in the history

  15. Add a comment

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    cf298b7 View commit details
    Browse the repository at this point in the history

  16. None records do not pass the WaitForDiscoverPolicy

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8cd05a4 View commit details
    Browse the repository at this point in the history

  17. format

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d1fb6ae View commit details
    Browse the repository at this point in the history

  18. remove second branch to ensure we always go through the same processing

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    124cfcf View commit details
    Browse the repository at this point in the history

  19. Raise an exception if the record is None

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a9ee16b View commit details
    Browse the repository at this point in the history

  20. reset

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a629ef0 View commit details
    Browse the repository at this point in the history

  21. Update tests

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f11a551 View commit details
    Browse the repository at this point in the history

  22. handle unquoted newlines

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    da274bc View commit details
    Browse the repository at this point in the history

  23. Automated Commit - Formatting Changes

    @girarda @octavia-squidington-iii
    girarda authored and octavia-squidington-iii committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b373221 View commit details
    Browse the repository at this point in the history

  24. Update test case so the quoting is explicit

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ce51b3d View commit details
    Browse the repository at this point in the history

  25. Merge branch 'alex/csv_options' of github.com:airbytehq/airbyte into … 

    …alex/csv_options
    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f8d76a1 View commit details
    Browse the repository at this point in the history

  26. Update comment

    @girarda
    girarda committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b857737 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Automated Commit - Formatting Changes

    @girarda @octavia-squidington-iii
    girarda authored and octavia-squidington-iii committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e8609c4 View commit details
    Browse the repository at this point in the history

  2. Fail validation if skipping rows before header and header is autogene… 

    …rated
    @girarda
    girarda committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    59f00be View commit details
    Browse the repository at this point in the history

  3. Merge branch 'alex/csv_options' of github.com:airbytehq/airbyte into … 

    …alex/csv_options
    @girarda
    girarda committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1cdaf60 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. always fail if a record cannot be parsed

    @girarda
    girarda committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d1c4036 View commit details
    Browse the repository at this point in the history

  2. merge

    @girarda
    girarda committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    903074a View commit details
    Browse the repository at this point in the history

  3. format

    @girarda
    girarda committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    bdfccee View commit details
    Browse the repository at this point in the history

  4. set write line_no in error message

    @girarda
    girarda committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    355d596 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. remove none check

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0426b4c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into alex/csv_options

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8b7d519 View commit details
    Browse the repository at this point in the history

  3. Automated Commit - Formatting Changes

    @girarda @octavia-squidington-iii
    girarda authored and octavia-squidington-iii committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8a7bcf7 View commit details
    Browse the repository at this point in the history

  4. enable autogenerate test

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9252651 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'alex/csv_options' of github.com:airbytehq/airbyte into … 

    …alex/csv_options
    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    06157dc View commit details
    Browse the repository at this point in the history

  6. remove duplicate test

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e5a1c0e View commit details
    Browse the repository at this point in the history

  7. missing unit tests

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9c9dc72 View commit details
    Browse the repository at this point in the history

  8. Update

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    146680a View commit details
    Browse the repository at this point in the history

  9. remove branching

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    4cfd721 View commit details
    Browse the repository at this point in the history

  10. remove unused none check

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    6f10047 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into alex/csv_options

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e4986e8 View commit details
    Browse the repository at this point in the history

  12. Update tests

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1f57507 View commit details
    Browse the repository at this point in the history

  13. remove branching

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0441c28 View commit details
    Browse the repository at this point in the history

  14. format

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    c2b3a37 View commit details
    Browse the repository at this point in the history

  15. extract to function

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d8538f9 View commit details
    Browse the repository at this point in the history

  16. comment

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    16df89d View commit details
    Browse the repository at this point in the history

  17. Merge branch 'master' into alex/csv_options

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7d7f6dd View commit details
    Browse the repository at this point in the history

  18. missing type

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    cef6a41 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'alex/csv_options' of github.com:airbytehq/airbyte into … 

    …alex/csv_options
    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    cec32dc View commit details
    Browse the repository at this point in the history

  20. type annotation

    @girarda
    girarda committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    05067a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. use set

    @girarda
    girarda committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    bdbd413 View commit details
    Browse the repository at this point in the history

  2. Document that the strings are case-sensitive

    @girarda
    girarda committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    bf525b4 View commit details
    Browse the repository at this point in the history

  3. public -> private

    @girarda
    girarda committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d32a94f View commit details
    Browse the repository at this point in the history

  4. add unit test

    @girarda
    girarda committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    69240b0 View commit details
    Browse the repository at this point in the history

  5. newline

    @girarda
    girarda committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    bfe4d47 View commit details
    Browse the repository at this point in the history