✨Destination Iceberg: Support server-managed storage config #28506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
nastra
force-pushed
the
iceberg-server-managed-storage-config
branch
from
892da12
to
d8ab05b
Compare
nastra
commented
Jul 20, 2023
| @@ -76,6 +75,7 @@ public Catalog genCatalog() { | |||
| if (isNotBlank(this.token)) { | |||
| properties.put(OAuth2Properties.TOKEN, this.token); | |||
| } | |||
| properties.put(CatalogProperties.WAREHOUSE_LOCATION, this.storageConfig.getWarehouseUri()); | |||
There was a problem hiding this comment.
The RESTCatalog in Iceberg uses this property here: https://github.com/apache/iceberg/blob/f3826bd9b1111d08262109df741ca8bf5aa0b697/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L855-L858
nastra
force-pushed
the
iceberg-server-managed-storage-config
branch
from
d8ab05b
to
bffd863
Compare
|
|
|
/approve-and-merge reason="Integration Test are passing but still with http url" |
|
All in!! |
octavia-approvington
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds a storage config that lets storage be managed by the server
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.