🎉 improvement: speed up mongodb schema discovery #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fut <fut.wrk@gmail.com>
Signed-off-by: fut <fut.wrk@gmail.com>
|
Nice! By limiting the scan to only 10k, could we be potentially missing some documents + props? |
|
That might happen, but that is a tradeoff for unstructured databases which we can not cover. Just imagine a MongoDB database with 1B documents like |
sherifnada
approved these changes
Apr 12, 2021
| @@cache[collection.name] = {} | ||
| airbyte_types.each_pair do |field, types| | ||
| # Has one specific type | ||
| if types.count == 1 |
There was a problem hiding this comment.
does it make sense to have a fallback type here in case there are more than one type? we typically use string as the type in other connectors
sherifnada
changed the title
sherifnada
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fut fut.wrk@gmail.com
What
Speed up the discovery phase for MongoDB source.
How
Full DB scan takes huge amount of time for large DBs. Thus we take only 10k documents to search for props and 1k documents to determine prop types.
Pre-merge Checklist
docker pull narrativebi/airbyte-source-mongodb:0.3.0)