Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 馃敡 - Fix envs map in kube overlays #2854

Merged
merged 2 commits into from Apr 12, 2021
Merged

fix: 馃敡 - Fix envs map in kube overlays #2854

merged 2 commits into from Apr 12, 2021

Conversation

afranzi
Copy link
Contributor

@afranzi afranzi commented Apr 12, 2021

What

This PR aims to solve the Kustomization issue with the env field since it should be envs.

How

  • Update Kustomization overlays.

Links of Interest

@jrhizor jrhizor self-requested a review April 12, 2021 17:53
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting us off the deprecated version of env setting!

@jrhizor jrhizor merged commit 7a7d541 into airbytehq:master Apr 12, 2021
@michel-tricot
Copy link
Contributor

Thank you @afranzi !!

@afranzi afranzi deleted the kube/fix-envs branch April 12, 2021 18:42
@wallies wallies mentioned this pull request Jul 24, 2021
26 tasks
davinchia pushed a commit that referenced this pull request Jul 24, 2021
Kustomize env to envs was changes in this PR, then somehow got reverted
#2854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants