Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Source Shopify: add new stream Disputes #28770

Merged
merged 6 commits into from Aug 4, 2023
Merged

✨ Source Shopify: add new stream Disputes #28770

merged 6 commits into from Aug 4, 2023

Conversation

efimmatytsin
Copy link
Contributor

What

We want sync disputes from shopify https://shopify.dev/docs/api/admin-rest/2022-10/resources/dispute#get-shopify-payments-disputes?initiated-at=2013-05-03

How

Create new incremental stream Disputes.

🚨 User Impact 🚨

None.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023 •
edited by sh4sh

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@efimmatytsin
Copy link
Contributor Author

@sh4sh Hello! I closed previous PR, and created this instead.

@efimmatytsin
Merge remote-tracking branch 'origin/master' into SCNTALS-1988
e79a897 
# Conflicts:
#	airbyte-integrations/connectors/source-shopify/Dockerfile
#	airbyte-integrations/connectors/source-shopify/metadata.yaml
@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Jul 27, 2023
@sh4sh sh4sh mentioned this pull request Jul 27, 2023
Closed
@sh4sh
Copy link
Contributor

sh4sh commented Jul 27, 2023 •
edited

Hey @efimmatytsin thanks for testing the pre-release image. Looks good! I don't have write access to your fork, so I added the required change for acceptance tests in #28803 where they're now running. Once those are passing, we can add the change to this PR and merge from here.

sh4sh
sh4sh approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@sh4sh sh4sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add acceptance tests bypass i.e. 19cc2da then LGTM 👍

@efimmatytsin
Copy link
Contributor Author

@sh4sh Hello! done!

@efimmatytsin
Copy link
Contributor Author

@sh4sh Hello! what next?

@sh4sh
Copy link
Contributor

sh4sh commented Aug 1, 2023 •
edited

Hey @efimmatytsin one last thing - could you please add a changelog entry to the connector doc? https://github.com/airbytehq/airbyte/blob/master/docs/integrations/sources/shopify.md

@efimmatytsin
Copy link
Contributor Author

@sh4sh Hello! Done.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 2, 2023
@efimmatytsin
Copy link
Contributor Author

@sh4sh Hello, if you need something else, please let me know!

@sh4sh
Copy link
Contributor

sh4sh commented Aug 4, 2023

/approve-and-merge reason="source-shopify failing on master, change tested separately"

@octavia-approvington
Copy link
Contributor

This looks fine!
Merged!
Imagine it being fine

@octavia-approvington octavia-approvington merged commit f1c89a1 into airbytehq:master Aug 4, 2023
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh4sh sh4sh sh4sh approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees

@sh4sh sh4sh

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/shopify team/tse Technical Support Engineers
Projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@efimmatytsin @sh4sh @octavia-approvington @marcosmarxm @octavia-squidington-iii