Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors-ci: increase connectors package install max duration #28858

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jul 31, 2023

During nightly build concurrent execution context some connectors take more than 10mn to complete their Connector Package Install step. Increasing the timeout to 20mn.
CF: https://airbytehq-team.slack.com/archives/C02TYE9QL9M/p1690797994052729?thread_ts=1690783339.381649&cid=C02TYE9QL9M

@alafanechere alafanechere force-pushed the augustin/connectors-ci/increase-connector-package-install-timeout branch from c6f8156 to 7533dde Compare July 31, 2023 12:40
@alafanechere alafanechere requested a review from a team July 31, 2023 12:42
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change itself seems fine, but... should installs really be taking 20 minutes?

Feels like we should investigate why these are taking so long.

@alafanechere
Copy link
Contributor Author

This change itself seems fine, but... should installs really be taking 20 minutes?
Feels like we should investigate why these are taking so long.

@pedroslopez My current hypothesis, without investigation, is that the step could be long in high concurrency context were multiple steps/connectors pipelines are running in parallel and some task might be blocking an other. I increased the timeout value to check if this hypothesis is valid.

@alafanechere alafanechere merged commit a339622 into master Jul 31, 2023
17 checks passed
@alafanechere alafanechere deleted the augustin/connectors-ci/increase-connector-package-install-timeout branch July 31, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants