Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Stripe: Add properties to customer_shipping field in invoices stream #28887

Merged
merged 2 commits into from Aug 1, 2023

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Jul 31, 2023

What

Broken schema for invoices stream
Fixed: https://github.com/airbytehq/oncall/issues/2609

How

Moved all the properties of customer shipping filed in invoices stream under a properties field.

🚨 User Impact 🚨

No

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jul 31, 2023
@lazebnyi lazebnyi changed the title Add properties to customer_shipping field in invoces stream Source Stripe: Add properties to customer_shipping field in invoices stream Jul 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit ea013c8741) - ❌

⏲️ Total pipeline duration: 09mn22s

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 31, 2023
@lazebnyi
Copy link
Collaborator Author

Manually tested with pre-release version 3.17.0-dev.ea013c8741 in workspace.

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 2fb7a12d4c) - ✅

⏲️ Total pipeline duration: 12mn05s

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@lazebnyi lazebnyi merged commit f45da1a into master Aug 1, 2023
26 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/2609-source-stripe-broken-schema branch August 1, 2023 09:03
bnchrch pushed a commit that referenced this pull request Aug 3, 2023
…stream (#28887)

* Add properties to customer_shipping field in invoces stream

* Bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe team/connectors-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants