✨ Source Hubspot: handle connection errors #28909

arsenlosenko · 2023-08-01T10:35:06Z

What

Improve handling of common connection errors as it is described in this issue:
#26515

How

By relying on description of linked issue I have added slightly better phrasing to errors that may happen during connector setup, and wrapped it into AirbyteTracedException, so it could be treated as config error in UI.

github-actions · 2023-08-01T10:35:28Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

octavia-squidington-iii · 2023-08-01T10:38:45Z

source-hubspot test report (commit `5a1b13ac9f`) - ❌

⏲️ Total pipeline duration: 01mn29s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌
Code format checks	❌
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-01T10:43:55Z

source-hubspot test report (commit `b5cebbfa7d`) - ❌

⏲️ Total pipeline duration: 01mn27s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌
Code format checks	❌
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-01T10:47:17Z

source-hubspot test report (commit `f8c95b1db6`) - ❌

⏲️ Total pipeline duration: 01mn21s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	❌
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-01T12:25:49Z

source-hubspot test report (commit `73dd220895`) - ❌

⏲️ Total pipeline duration: 01mn23s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-02T09:25:39Z

source-hubspot test report (commit `5fb3737456`) - ❌

⏲️ Total pipeline duration: 03mn13s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌
Code format checks	❌
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-02T09:32:26Z

source-hubspot test report (commit `2f225b258f`) - ❌

⏲️ Total pipeline duration: 02mn58s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

…ource-connection-errors

octavia-squidington-iii · 2023-08-02T12:09:05Z

source-hubspot test report (commit `04291cd22f`) - ❌

⏲️ Total pipeline duration: 02mn42s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

…ource-connection-errors

octavia-squidington-iii · 2023-08-03T10:35:13Z

source-hubspot test report (commit `047be356f2`) - ❌

⏲️ Total pipeline duration: 11mn17s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

bazarnov · 2023-08-03T13:29:14Z

@arsenlosenko Please fix the expected records to pass the CAT. And re-request the review once the CAT is passed successfully. Thank you.

…ource-connection-errors

octavia-squidington-iii · 2023-08-04T08:53:38Z

source-hubspot test report (commit `64b69da037`) - ❌

⏲️ Total pipeline duration: 11mn10s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-04T09:14:24Z

source-hubspot test report (commit `c57afed2f1`) - ✅

⏲️ Total pipeline duration: 11mn27s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

…ource-connection-errors

octavia-squidington-iii · 2023-08-07T08:59:59Z

source-hubspot test report (commit `59a0c649d7`) - ❌

⏲️ Total pipeline duration: 11mn25s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-07T09:22:18Z

source-hubspot test report (commit `42ba3e12f3`) - ✅

⏲️ Total pipeline duration: 11mn11s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

Source Hubspot: handle connection errors

5a1b13a

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot labels Aug 1, 2023

Update changelog

b5cebbf

arsenlosenko self-assigned this Aug 1, 2023

arsenlosenko linked an issue Aug 1, 2023 that may be closed by this pull request

Improve HubSpot source connection errors #26515

Closed

Fix format errors

f8c95b1

Fix imports

73dd220

Update custom errors, fix unit tests

5fb3737

Remove unused import

2f225b2

Merge branch 'master' into arsenlosenko/26515-source-hubspot-import-s…

04291cd

…ource-connection-errors

Merge branch 'master' into arsenlosenko/26515-source-hubspot-import-s…

047be35

…ource-connection-errors

arsenlosenko requested review from bazarnov and lazebnyi August 3, 2023 10:23

Merge branch 'master' into arsenlosenko/26515-source-hubspot-import-s…

64b69da

…ource-connection-errors

Update expected records, fix docs

c57afed

bazarnov approved these changes Aug 4, 2023

View reviewed changes

Merge branch 'master' into arsenlosenko/26515-source-hubspot-import-s…

59a0c64

…ource-connection-errors

Update deals expected records

42ba3e1

arsenlosenko merged commit 7944410 into master Aug 7, 2023
22 checks passed

arsenlosenko deleted the arsenlosenko/26515-source-hubspot-import-source-connection-errors branch August 7, 2023 09:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Source Hubspot: handle connection errors #28909

✨ Source Hubspot: handle connection errors #28909

arsenlosenko commented Aug 1, 2023 •

edited

Loading

github-actions bot commented Aug 1, 2023 •

edited by arsenlosenko

Loading

octavia-squidington-iii commented Aug 1, 2023

octavia-squidington-iii commented Aug 1, 2023

octavia-squidington-iii commented Aug 1, 2023

octavia-squidington-iii commented Aug 1, 2023

octavia-squidington-iii commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

octavia-squidington-iii commented Aug 3, 2023

bazarnov commented Aug 3, 2023

octavia-squidington-iii commented Aug 4, 2023

octavia-squidington-iii commented Aug 4, 2023

octavia-squidington-iii commented Aug 7, 2023

octavia-squidington-iii commented Aug 7, 2023

✨ Source Hubspot: handle connection errors #28909

✨ Source Hubspot: handle connection errors #28909

Conversation

arsenlosenko commented Aug 1, 2023 • edited Loading

What

How

github-actions bot commented Aug 1, 2023 • edited by arsenlosenko Loading

Before Merging a Connector Pull Request

octavia-squidington-iii commented Aug 1, 2023

source-hubspot test report (commit 5a1b13ac9f) - ❌

octavia-squidington-iii commented Aug 1, 2023

source-hubspot test report (commit b5cebbfa7d) - ❌

octavia-squidington-iii commented Aug 1, 2023

source-hubspot test report (commit f8c95b1db6) - ❌

octavia-squidington-iii commented Aug 1, 2023

source-hubspot test report (commit 73dd220895) - ❌

octavia-squidington-iii commented Aug 2, 2023

source-hubspot test report (commit 5fb3737456) - ❌

octavia-squidington-iii commented Aug 2, 2023

source-hubspot test report (commit 2f225b258f) - ❌

octavia-squidington-iii commented Aug 2, 2023

source-hubspot test report (commit 04291cd22f) - ❌

octavia-squidington-iii commented Aug 3, 2023

source-hubspot test report (commit 047be356f2) - ❌

bazarnov commented Aug 3, 2023

octavia-squidington-iii commented Aug 4, 2023

source-hubspot test report (commit 64b69da037) - ❌

octavia-squidington-iii commented Aug 4, 2023

source-hubspot test report (commit c57afed2f1) - ✅

octavia-squidington-iii commented Aug 7, 2023

source-hubspot test report (commit 59a0c649d7) - ❌

octavia-squidington-iii commented Aug 7, 2023

source-hubspot test report (commit 42ba3e12f3) - ✅

arsenlosenko commented Aug 1, 2023 •

edited

Loading

github-actions bot commented Aug 1, 2023 •

edited by arsenlosenko

Loading

source-hubspot test report (commit `5a1b13ac9f`) - ❌

source-hubspot test report (commit `b5cebbfa7d`) - ❌

source-hubspot test report (commit `f8c95b1db6`) - ❌

source-hubspot test report (commit `73dd220895`) - ❌

source-hubspot test report (commit `5fb3737456`) - ❌

source-hubspot test report (commit `2f225b258f`) - ❌

source-hubspot test report (commit `04291cd22f`) - ❌

source-hubspot test report (commit `047be356f2`) - ❌

source-hubspot test report (commit `64b69da037`) - ❌

source-hubspot test report (commit `c57afed2f1`) - ✅

source-hubspot test report (commit `59a0c649d7`) - ❌

source-hubspot test report (commit `42ba3e12f3`) - ✅