Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Github, Instagram, Zendesk-support, Zendesk-talk: fix CAT tests fail on spec #28910

Merged
merged 8 commits into from Aug 3, 2023
Merged

🐛 Source Github, Instagram, Zendesk-support, Zendesk-talk: fix CAT tests fail on spec #28910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
91dba87
updated
bazarnov Aug 1, 2023
cb75e0e
updated changelog
bazarnov Aug 1, 2023
9ce54c0
updated zendesk-support expected records
bazarnov Aug 1, 2023
b5d1d5d
updated
bazarnov Aug 2, 2023
e2475cc
Merge branch 'master' into baz/source-github-instagram-zendesk-supppo…
bazarnov Aug 2, 2023
8297b9b
Merge branch 'master' into baz/source-github-instagram-zendesk-supppo…
bazarnov Aug 2, 2023
c19ee9e
Merge branch 'master' into baz/source-github-instagram-zendesk-supppo…
bazarnov Aug 2, 2023
ec01fd2
dummy update
bazarnov Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-github/Dockerfile
View file
Open in desktop
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=1.0.2
LABEL io.airbyte.version=1.0.3
LABEL io.airbyte.name=airbyte/source-github
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-github/metadata.yaml
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: ef69ef6e-aa7f-4af1-a01d-ef775033524e
dockerImageTag: 1.0.2
dockerImageTag: 1.0.3
maxSecondsBetweenMessages: 5400
dockerRepository: airbyte/source-github
githubIssueLabel: source-github
Expand Down
14 changes: 0 additions & 14 deletions airbyte-integrations/connectors/source-github/source_github/spec.json
View file
Open in desktop
Expand Up @@ -117,20 +117,6 @@
"type": "string"
}
}
},
"complete_oauth_server_output_specification": {
"type": "object",
"additionalProperties": false,
"properties": {
"client_id": {
"type": "string",
"path_in_connector_config": ["credentials", "client_id"]
},
"client_secret": {
"type": "string",
"path_in_connector_config": ["credentials", "client_secret"]
}
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-instagram/Dockerfile
View file
Open in desktop
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=1.0.9
LABEL io.airbyte.version=1.0.10
LABEL io.airbyte.name=airbyte/source-instagram
17 changes: 0 additions & 17 deletions airbyte-integrations/connectors/source-instagram/integration_tests/spec.json
View file
Open in desktop
Expand Up @@ -48,23 +48,6 @@
"type": "string"
}
}
},
"complete_oauth_server_output_specification": {
"type": "object",
"properties": {
"client_id": {
"type": "string",
"path_in_connector_config": [
"client_id"
]
},
"client_secret": {
"type": "string",
"path_in_connector_config": [
"client_secret"
]
}
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-instagram/metadata.yaml
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 6acf6b55-4f1e-4fca-944e-1a3caef8aba8
dockerImageTag: 1.0.9
dockerImageTag: 1.0.10
dockerRepository: airbyte/source-instagram
githubIssueLabel: source-instagram
icon: instagram.svg
Expand Down
7 changes: 0 additions & 7 deletions airbyte-integrations/connectors/source-instagram/source_instagram/source.py
View file
Open in desktop
Expand Up @@ -96,13 +96,6 @@ def spec(self, *args, **kwargs) -> ConnectorSpecification:
"type": "object",
"properties": {"client_id": {"type": "string"}, "client_secret": {"type": "string"}},
},
complete_oauth_server_output_specification={
"type": "object",
"properties": {
"client_id": {"type": "string", "path_in_connector_config": ["client_id"]},
"client_secret": {"type": "string", "path_in_connector_config": ["client_secret"]},
},
},
),
),
)
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/Dockerfile
View file
Open in desktop
Expand Up @@ -25,5 +25,5 @@ COPY source_zendesk_support ./source_zendesk_support
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.10.4
LABEL io.airbyte.version=0.10.5
LABEL io.airbyte.name=airbyte/source-zendesk-support
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/README.md
View file
Open in desktop
Expand Up @@ -129,4 +129,4 @@ You've checked out the repo, implemented a million dollar feature, and you're re
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)).
1. Create a Pull Request.
1. Pat yourself on the back for being an awesome contributor.
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
4 changes: 1 addition & 3 deletions airbyte-integrations/connectors/source-zendesk-support/acceptance-test-config.yml
View file
Open in desktop
Expand Up @@ -29,9 +29,6 @@ acceptance_tests:
extra_records: yes
fail_on_extra_columns: false
empty_streams:
# This stream is only available for enterprise accounts https://developer.zendesk.com/api-reference/ticketing/account-configuration/audit_logs/
- name: "audit_logs"
bypass_reason: "no records"
- name: "post_comments"
bypass_reason: "not available in current subscription plan"
- name: "post_votes"
Expand All @@ -46,6 +43,7 @@ acceptance_tests:
future_state_path: "integration_tests/abnormal_state.json"
cursor_paths:
ticket_comments: ["created_at"]
threshold_days: 100
full_refresh:
tests:
- config_path: "secrets/config.json"
Expand Down
115 changes: 60 additions & 55 deletions ...e-integrations/connectors/source-zendesk-support/integration_tests/expected_records.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ data:
connectorType: source
maxSecondsBetweenMessages: 10800
definitionId: 79c1aa37-dae3-42ae-b333-d1c105477715
dockerImageTag: 0.10.4
dockerImageTag: 0.10.5
dockerRepository: airbyte/source-zendesk-support
githubIssueLabel: source-zendesk-support
icon: zendesk-support.svg
Expand Down
14 changes: 0 additions & 14 deletions airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/spec.json
View file
Open in desktop
Expand Up @@ -106,20 +106,6 @@
}
}
},
"complete_oauth_server_output_specification": {
"type": "object",
"additionalProperties": false,
"properties": {
"client_id": {
"type": "string",
"path_in_connector_config": ["credentials", "client_id"]
},
"client_secret": {
"type": "string",
"path_in_connector_config": ["credentials", "client_secret"]
}
}
},
"oauth_user_input_from_connector_config_specification": {
"type": "object",
"additionalProperties": false,
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-talk/Dockerfile
View file
Open in desktop
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.7
LABEL io.airbyte.version=0.1.8
LABEL io.airbyte.name=airbyte/source-zendesk-talk
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-talk/metadata.yaml
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: c8630570-086d-4a40-99ae-ea5b18673071
dockerImageTag: 0.1.7
dockerImageTag: 0.1.8
dockerRepository: airbyte/source-zendesk-talk
githubIssueLabel: source-zendesk-talk
icon: zendesk-talk.svg
Expand Down
14 changes: 0 additions & 14 deletions airbyte-integrations/connectors/source-zendesk-talk/source_zendesk_talk/spec.json
View file
Open in desktop
Expand Up @@ -100,20 +100,6 @@
}
}
},
"complete_oauth_server_output_specification": {
"type": "object",
"additionalProperties": false,
"properties": {
"client_id": {
"type": "string",
"path_in_connector_config": ["credentials", "client_id"]
},
"client_secret": {
"type": "string",
"path_in_connector_config": ["credentials", "client_secret"]
}
}
},
"oauth_user_input_from_connector_config_specification": {
"type": "object",
"additionalProperties": false,
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/github.md
View file
Open in desktop
Expand Up @@ -163,6 +163,7 @@ The GitHub connector should not run into GitHub API limitations under normal usa

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:------------------------------------------------------------------------------------------------------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 1.0.3 | 2023-08-01 | [28910](https://github.com/airbytehq/airbyte/pull/28910) | Updated `advancedAuth` broken references |
| 1.0.2 | 2023-07-11 | [28144](https://github.com/airbytehq/airbyte/pull/28144) | Add `archived_at` property to `Organizations` schema parameter |
| 1.0.1 | 2023-05-22 | [25838](https://github.com/airbytehq/airbyte/pull/25838) | Deprecate "page size" input parameter |
| 1.0.0 | 2023-05-19 | [25778](https://github.com/airbytehq/airbyte/pull/25778) | Improve repo(s) name validation on UI |
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/instagram.md
View file
Open in desktop
Expand Up @@ -82,6 +82,7 @@ AirbyteRecords are required to conform to the [Airbyte type](https://docs.airbyt

| Version | Date | Pull Request | Subject |
|:--------|:-----|:-------------|:--------|
| 1.0.10 | 2023-08-01 | [28910](https://github.com/airbytehq/airbyte/pull/28910) | Updated `advancedAuth` broken references |
| 1.0.9 | 2023-07-01 | [27908](https://github.com/airbytehq/airbyte/pull/27908) | Fix bug when `user_lifetime_insights` stream returns `Key Error (end_time)`, refactored `state` to use `IncrementalMixin` |
| 1.0.8 | 2023-05-26 | [26767](https://github.com/airbytehq/airbyte/pull/26767) | Handle permission error for `insights` |
| 1.0.7 | 2023-05-26 | [26656](https://github.com/airbytehq/airbyte/pull/26656) | Remove `authSpecification` from connector specification in favour of `advancedAuth` |
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/zendesk-support.md
View file
Open in desktop
Expand Up @@ -79,6 +79,7 @@ The Zendesk connector ideally should not run into Zendesk API limitations under

| Version | Date | Pull Request | Subject |
|:---------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `0.10.5` | 2023-08-01 | [28910](https://github.com/airbytehq/airbyte/pull/28910) | Updated `advancedAuth` broken references |
| `0.10.4` | 2023-07-25 | [28397](https://github.com/airbytehq/airbyte/pull/28397) | Handle 404 Error |
| `0.10.3` | 2023-07-24 | [28612](https://github.com/airbytehq/airbyte/pull/28612) | Fix pagination for stream `TicketMetricEvents` |
| `0.10.2` | 2023-07-19 | [28487](https://github.com/airbytehq/airbyte/pull/28487) | Remove extra page from params |
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/zendesk-talk.md
View file
Open in desktop
Expand Up @@ -76,6 +76,7 @@ The Zendesk connector should not run into Zendesk API limitations under normal u

| Version | Date | Pull Request | Subject |
|:--------|:-----------| :----- |:----------------------------------|
| `0.1.8` | 2023-08-01 | [28910](https://github.com/airbytehq/airbyte/pull/28910) | Updated `advancedAuth` broken references |
| `0.1.7` | 2023-02-10 | [22815](https://github.com/airbytehq/airbyte/pull/22815) | Specified date formatting in specification |
| `0.1.6` | 2023-01-27 | [22028](https://github.com/airbytehq/airbyte/pull/22028) | Set `AvailabilityStrategy` for streams explicitly to `None` |
| `0.1.5` | 2022-09-29 | [17362](https://github.com/airbytehq/airbyte/pull/17362) | always use the latest CDK version |
Expand Down