Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Auth0: Migrate Python CDK to Low-code CDK #28972

Merged
merged 44 commits into from Aug 23, 2023

Conversation

btkcodedev
Copy link
Collaborator

What

Migrating Source Auth0 to Low-Code CDK
Closes #28928

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

Tests

Integration & Acceptance Full Test Results

image

🚨 User Impact 🚨

  • No breaking changes, migration to low-code
Migrate Connector: Source Auth0

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/auth0 labels Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@btkcodedev
Copy link
Collaborator Author

PS: All tests are passing, Please ping via slack for getting credentials.
Slack ID: btkcodedev

@marcosmarxm
Copy link
Member

@btkcodedev let's wait for #29001 to get merged.

@marcosmarxm
Copy link
Member

@btkcodedev can you fix the conflicts and implement the new 3 streams? Thanks!

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Aug 5, 2023

@sajarin @marcosmarxm
Streams added,
Manifest fixed,
Added incremental sync

Test result - All passed state :)

image

@btkcodedev
Copy link
Collaborator Author

@sajarin setup.py had conflicts, Cleared 'em all and updated expected records,
basic read and incremental are all passing :)

@btkcodedev
Copy link
Collaborator Author

@sajarin Pagination implemented

@sajarin
Copy link
Contributor

sajarin commented Aug 15, 2023

Thanks @btkcodedev, currently running tests in the PR above, the tests seem to have timed out before so investigating that at the moment.

@sajarin
Copy link
Contributor

sajarin commented Aug 21, 2023

@btkcodedev tested using the new credentials you shared through slack, running into failing incremental tests: namely test_two_sequential_reads and test_read_sequential_slices. Both seem to fail when comparing the state and records cursors:

image

image

@sajarin sajarin merged commit 5fbe08c into airbytehq:master Aug 23, 2023
37 of 39 checks passed
@sajarin
Copy link
Contributor

sajarin commented Aug 23, 2023

Thanks for the contribution @btkcodedev!

@btkcodedev
Copy link
Collaborator Author

Thank you @sajarin for your continuous efforts 🔥💫❤️

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Co-authored-by: Sajarin <sajarindider@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/auth0 connectors/source/mailgun Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers
Projects
Development

Successfully merging this pull request may close these issues.

Auth0
4 participants