Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Marketo - filter 'null' byte(s) in HTTP responses #28999

Closed
wants to merge 7 commits into from

Conversation

richa-rochna
Copy link
Contributor

@richa-rochna richa-rochna commented Aug 2, 2023

What

Source Marketo version 1.2.0 fails with _csv.Error: line contains NUL. Fixing this issue.

How

filtering out 'null' byte(s) in HTTP responses

Recommended reading order

  1. spec.json
  2. source.py

🚨 User Impact 🚨

No breaking changes. 'null' byte(s) will be filtered out from response.

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 2, 2023
@marcosmarxm
Copy link
Member

Thanks for the contribution @richa-rochna soon the team will review it.

@bmcgilli
Copy link
Contributor

@lazebnyi can you please assign for review? this one is very helpful, thanks!

@marcosmarxm
Copy link
Member

Thanks for the contribution @richa-rochna and sorry for the lack of updates. I'll review during the week 🙇 !

@lazebnyi
Copy link
Collaborator

lazebnyi commented Nov 29, 2023

@askarpets please take a look for review

Copy link
Contributor

@askarpets askarpets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richa-rochna, thank you for your PR! I left some small comments, but overall looks good!

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ❌ Failed (Inspect) Nov 30, 2023 7:45pm

Copy link
Contributor

@askarpets askarpets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR, but please resolve the conflicts.

@richa-rochna
Copy link
Contributor Author

Approving this PR, but please resolve the conflicts.

@askarpets Thanks for the approval. I have resolved the conflicts. Would you be able to merge?

@askarpets
Copy link
Contributor

Hi @marcosmarxm, could you please merge this PR?

@marcosmarxm
Copy link
Member

Merged at #33623 thanks @richa-rochna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants