New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Marketo - filter 'null' byte(s) in HTTP responses #28999
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Thanks for the contribution @richa-rochna soon the team will review it. |
@lazebnyi can you please assign for review? this one is very helpful, thanks! |
Thanks for the contribution @richa-rochna and sorry for the lack of updates. I'll review during the week 🙇 ! |
@askarpets please take a look for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richa-rochna, thank you for your PR! I left some small comments, but overall looks good!
airbyte-integrations/connectors/source-marketo/unit_tests/test_source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/unit_tests/test_source.py
Outdated
Show resolved
Hide resolved
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR, but please resolve the conflicts.
@askarpets Thanks for the approval. I have resolved the conflicts. Would you be able to merge? |
Hi @marcosmarxm, could you please merge this PR? |
Merged at #33623 thanks @richa-rochna |
What
Source Marketo version 1.2.0 fails with _csv.Error: line contains NUL. Fixing this issue.
How
filtering out 'null' byte(s) in HTTP responses
Recommended reading order
spec.json
source.py
🚨 User Impact 🚨
No breaking changes. 'null' byte(s) will be filtered out from response.
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.