connectors-ci: disable tui on prelease #29034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
changed the title
alafanechere
force-pushed
the
augustin/connectors-ci/disable-tui-on-prelease
branch
from
19e6847
to
632ca0f
Compare
erohmensing
approved these changes
Aug 3, 2023
Comment on lines
+93
to
+94
| if len(sys.argv) > 1 and any([arg in ARGS_DISABLING_TUI for arg in sys.argv]): | ||
| command = ["airbyte-ci-internal"] + [arg for arg in sys.argv[1:] if arg != "--no-tui"] |
There was a problem hiding this comment.
More robust than looking at a specific index 👌🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #29000
The Dagger terminal UI is not interactive: user prompts do not work.
We have a user prompt on publish.
How
Disable Dagger TUI on
publish