source-mysql : chunking queries impl #29109

akashkulk · 2023-08-04T21:11:58Z

Reading order + major changes :

MySqlInitialLoadRecordIterator.java : New record that implements the chunking logic. Continuously makes queries to the database with the configured chunk size and previously processed high watermark of PK value evaluated. Previous logic of creating prepared statements has been moved to this class from MySqlInitialLoadHandler. e.g.

Query 1 : select * from table order by pk limit 1,800,000
Query 2 : select * from table where pk > pk_max_1 order by pk limit 1,800,000
Query 3 : select * from table where pk > pk_max_2 order by pk limit 1,800,000

MySqlQueryUtils.java : Queries the size and average row length of each table in initial load.
MySqlInitialLoadHandler.java: Logic to calculate the chunk (limit size) used in the above queries. Each chunk should correspond to about ~1GB of data.
MySqlInitialSyncStateIterator.java, MySqlLoadGlobalStateManager.java : Adds interface to update the primary key watermark processed. This is needed to dynamically calculate pk_max_1, pk_max_2 in the example above.
MySqlInitialLoadSourceOperations.java : Small bug fix to process null values. In line with the parent class at AbstractjdbcSourceOperations.java.
Tests : Added tests for limit size calculation. Existing test suite should be unchanged since number of records processed + state messages emitted should stay the same

Some other changes :

Update state emission for initial load from 10_000 to 100_000 to reduce log verbosity and alleviate the pressure from large state message size. There doesn't seem to be any benefit for having such a high frequency emission.

Sync logs from local testing :
26af7a74_0437_42a9_9b17_981b4c659fff_logs_57_txt.txt

github-actions · 2023-08-04T21:12:18Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

akashkulk · 2023-08-17T22:11:32Z

/legacy-test connector=connectors/source-mysql

github-actions · 2023-08-17T22:27:30Z

source-mysql test report (commit `0583a62798`) - ❌

⏲️ Total pipeline duration: 20mn24s

Step	Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	❌
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql:integrationTest	❌
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

github-actions · 2023-08-17T22:49:08Z

source-mysql test report (commit `48a7c4b386`) - ❌

⏲️ Total pipeline duration: 19mn29s

Step	Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	❌
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql:integrationTest	❌
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

akashkulk · 2023-08-17T23:25:06Z

/legacy-test connector=connectors/source-mysql

github-actions · 2023-08-17T23:50:53Z

source-mysql test report (commit `bfbc132528`) - ❌

⏲️ Total pipeline duration: 20mn56s

Step	Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	❌
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql:integrationTest	❌
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

github-actions · 2023-08-18T00:06:53Z

source-mysql-strict-encrypt test report (commit `12aabb2cd9`) - ❌

⏲️ Total pipeline duration: 13mn37s

Step	Result
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌
Build connector tar	✅
Build source-mysql-strict-encrypt docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql-strict-encrypt:integrationTest	❌
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

github-actions · 2023-08-18T00:24:06Z

source-mysql test report (commit `12aabb2cd9`) - ❌

⏲️ Total pipeline duration: 17mn03s

Step	Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql:integrationTest	❌
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

akashkulk · 2023-08-18T03:55:05Z

/legacy-test connector=connectors/source-mysql

github-actions · 2023-08-18T04:50:38Z

source-mysql test report (commit `f6fbdb059f`) - ❌

⏲️ Total pipeline duration: 20mn43s

Step	Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql:integrationTest	❌
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

github-actions · 2023-08-18T05:03:48Z

source-mysql-strict-encrypt test report (commit `f6fbdb059f`) - ❌

⏲️ Total pipeline duration: 13mn00s

Step	Result
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌
Build connector tar	✅
Build source-mysql-strict-encrypt docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql-strict-encrypt:integrationTest	❌
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

github-actions · 2023-08-18T05:25:45Z

source-mysql test report (commit `9911361aee`) - ❌

⏲️ Total pipeline duration: 19mn31s

Step	Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	❌
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql:integrationTest	❌
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

akashkulk · 2023-08-18T17:16:09Z

/legacy-test connector=connectors/source-mysql

github-actions · 2023-08-18T17:40:20Z

source-mysql test report (commit `3b3b92df36`) - ❌

⏲️ Total pipeline duration: 21mn04s

Step	Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	❌
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql:integrationTest	❌
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

github-actions · 2023-08-18T18:36:39Z

source-mysql test report (commit `d541b4b79a`) - ❌

⏲️ Total pipeline duration: 20mn44s

Step	Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	❌
Build connector tar	✅
Build source-mysql docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-mysql:integrationTest	❌
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

akashkulk · 2023-08-18T19:26:03Z

/approve-and-merge reason="mysql tests passing"

octavia-approvington · 2023-08-18T19:26:38Z

All in!!

akashkulk and others added 13 commits July 26, 2023 14:59

Initial Commit of CDC PK snapshotting

8e11974

Merge branch 'master' into mysql_chkpt_prototype

d48f206

Added unit tests

083835f

Flip to true

d3a0082

Refactor flags

16a1b9b

Re-add flag

bd7f1bc

Merge branch 'master' into mysql_chkpt_prototype

58feb66

Comment cleanup

33725b7

Merge branch 'master' into mysql_chkpt_prototype

2f91ac4

Code review comments

eb046e7

Merge branch 'master' into mysql_chkpt_prototype

a0805a8

Merge branch 'master' into mysql_chkpt_prototype

6919e06

First pass at chunking logic

9ab2584

octavia-squidington-iii added area/connectors Connector related issues connectors/source/mysql connectors/source/postgres labels Aug 4, 2023

akashkulk and others added 12 commits August 4, 2023 14:27

Merge branch 'master' into chunking_chkpt

3e1adae

Merge branch 'master' into chunking_chkpt

42e8071

Revert merge conflicted files

d3992eb

Query for table estimate

c7d24a8

Merge branch 'master' into chunking_chkpt

1617aef

Add records to state

4332016

Query iterator prototyping continuation

d3a141a

Chunking working

f0ca9d9

Merge branch 'master' into chunking_chkpt

82b7831

Reverting files that aren't needed

3aa327c

Revert more unneeded files

2c472fd

Implement chunking logic

969f0a8

akashkulk marked this pull request as ready for review August 11, 2023 12:33

Merge branch 'master' into chunking_chkpt

48a7c4b

akashkulk and others added 2 commits August 17, 2023 16:27

Merge branch 'master' into chunking_chkpt

bfbc132

Enabling for creating dev image

12aabb2

octavia-squidington-iii added the connectors/source/mysql-strict-encrypt label Aug 17, 2023

akashkulk mentioned this pull request Aug 18, 2023

source-mysql : Chunking logic sync bugs in case of composite primary key #29574

Closed

akashkulk and others added 3 commits August 17, 2023 21:27

Revert mysql change

f6fbdb0

Merge branch 'master' into chunking_chkpt

1f3723e

Reverting hack to pre-publish

9911361

Merge branch 'master' into chunking_chkpt

3b3b92d

Merge branch 'master' into chunking_chkpt

d541b4b

octavia-approvington approved these changes Aug 18, 2023

View reviewed changes

octavia-approvington merged commit 2b18864 into master Aug 18, 2023
17 of 21 checks passed

octavia-approvington deleted the chunking_chkpt branch August 18, 2023 19:26

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023

source-mysql : chunking queries impl (airbytehq#29109)

087e398

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

source-mysql : chunking queries impl #29109

source-mysql : chunking queries impl #29109

akashkulk commented Aug 4, 2023 •

edited

github-actions bot commented Aug 4, 2023

akashkulk commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

akashkulk commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

akashkulk commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

akashkulk commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

akashkulk commented Aug 18, 2023

octavia-approvington commented Aug 18, 2023

source-mysql : chunking queries impl #29109

source-mysql : chunking queries impl #29109

Conversation

akashkulk commented Aug 4, 2023 • edited

github-actions bot commented Aug 4, 2023

Before Merging a Connector Pull Request

akashkulk commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

source-mysql test report (commit 0583a62798) - ❌

github-actions bot commented Aug 17, 2023

source-mysql test report (commit 48a7c4b386) - ❌

akashkulk commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

source-mysql test report (commit bfbc132528) - ❌

github-actions bot commented Aug 18, 2023

source-mysql-strict-encrypt test report (commit 12aabb2cd9) - ❌

github-actions bot commented Aug 18, 2023

source-mysql test report (commit 12aabb2cd9) - ❌

akashkulk commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

source-mysql test report (commit f6fbdb059f) - ❌

github-actions bot commented Aug 18, 2023

source-mysql-strict-encrypt test report (commit f6fbdb059f) - ❌

github-actions bot commented Aug 18, 2023

source-mysql test report (commit 9911361aee) - ❌

akashkulk commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

source-mysql test report (commit 3b3b92df36) - ❌

github-actions bot commented Aug 18, 2023

source-mysql test report (commit d541b4b79a) - ❌

akashkulk commented Aug 18, 2023

octavia-approvington commented Aug 18, 2023

akashkulk commented Aug 4, 2023 •

edited

source-mysql test report (commit `0583a62798`) - ❌

source-mysql test report (commit `48a7c4b386`) - ❌

source-mysql test report (commit `bfbc132528`) - ❌

source-mysql-strict-encrypt test report (commit `12aabb2cd9`) - ❌

source-mysql test report (commit `12aabb2cd9`) - ❌

source-mysql test report (commit `f6fbdb059f`) - ❌

source-mysql-strict-encrypt test report (commit `f6fbdb059f`) - ❌

source-mysql test report (commit `9911361aee`) - ❌

source-mysql test report (commit `3b3b92df36`) - ❌

source-mysql test report (commit `d541b4b79a`) - ❌