Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Migrate Confluence Source Connector to Low Code #29125

Merged
merged 20 commits into from Aug 18, 2023

Conversation

topefolorunso
Copy link
Collaborator

What

Migrating Source Confluence to Low-Code CDK resolves #28989

How

Created the connector using the connector buider UI, then imported the manifest.yaml to the low code cdk.

Recommended reading order

  1. manifest.yaml

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Aug 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@sajarin sajarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, left some comments:

@marcosmarxm marcosmarxm added the Hackathon External low-code/ui connector builder hackathons label Aug 9, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 14, 2023
Copy link
Contributor

@sajarin sajarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the schema files with "additionalProperties" set to true?

@topefolorunso
Copy link
Collaborator Author

Can you update the schema files with "additionalProperties" set to true?

Fixed @sajarin

@sajarin
Copy link
Contributor

sajarin commented Aug 14, 2023

@topefolorunso there are some validation errors in the manifest.yaml. Please correct them and then attach screenshots of passing acceptance tests

@topefolorunso
Copy link
Collaborator Author

@topefolorunso there are some validation errors in the manifest.yaml. Please correct them and then attach screenshots of passing acceptance tests

Validation error fixed @sajarin

image

@sajarin
Copy link
Contributor

sajarin commented Aug 15, 2023

@topefolorunso some more errors after running the tests:

image image

@topefolorunso
Copy link
Collaborator Author

@sajarin Errors should be fixed now.

  • The audit stream requires a premium account which I don't have. So I was unable to test the stream. Kindly test again and let me know if anything else is broken.
  • The pk used previously was the "author" property which is not unique. Apparently, there is no unique id for each audit log, so I opted for the "creationDate" property which is expected to be unique. (I hope that is okay)
  • Finally, for some reason, I have been unable to run integration tests for all my connectors, probably due to some recent changes in the codebase. Please advise.

@sajarin
Copy link
Contributor

sajarin commented Aug 17, 2023

Still running into some issue with the primary keys but running the tests in a separate PR as per our usual review process.

@sajarin sajarin changed the title Migrate Confluence Source Connector to Low Code 🎉 Migrate Confluence Source Connector to Low Code Aug 18, 2023
@sajarin
Copy link
Contributor

sajarin commented Aug 18, 2023

Thanks for the contribution @topefolorunso!

@sajarin sajarin merged commit 528127a into airbytehq:master Aug 18, 2023
38 of 40 checks passed
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/confluence Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers
Projects
Development

Successfully merging this pull request may close these issues.

confluence
4 participants