Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source FreshServices : Migrate Python CDK to Low-code CDK #29126

Merged

Conversation

avirajsingh7
Copy link
Contributor

@avirajsingh7 avirajsingh7 commented Aug 6, 2023

What

Migrating Source freshservices to Low-Code CDK
Closes #28992

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?
Yes, there are breaking changes due to Changes to Stream Schema
At many places previous data type were wrong and added some new properties in schema as per response from API

Test

Acceptance Test Screenshot 2023-08-06 at 3 59 04 PM
Migrate Connector : Source FreshServices
  • Community Member? Grant Edit Access to Maintainers instructions
  • Secrets in the Connector's Spec
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors::integrationTest.
  • Code Reviews Completed
    • Documentation Updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations//.md (including changelog. See changelog example)
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR Name follows PR Naming Conventions

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 6, 2023
@marcosmarxm marcosmarxm added hackathon-2023-08 team/tse Technical Support Engineers Hackathon External low-code/ui connector builder hackathons labels Aug 7, 2023
Copy link
Contributor

@archangelic archangelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution! This overall looks great! I have a few small changes for you!

docs/integrations/sources/freshservice.md Outdated Show resolved Hide resolved
@avirajsingh7
Copy link
Contributor Author

@archangelic done changes

Copy link
Contributor

@archangelic archangelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some changes to get acceptance tests working!

avirajsingh7 and others added 4 commits August 16, 2023 09:56
Co-authored-by: Mal Hancock <mhancock@archangelic.space>
Co-authored-by: Mal Hancock <mhancock@archangelic.space>
Co-authored-by: Mal Hancock <mhancock@archangelic.space>
@avirajsingh7
Copy link
Contributor Author

@archangelic anything else

@archangelic archangelic mentioned this pull request Aug 16, 2023
@archangelic
Copy link
Contributor

Everything looks good! Going to merge this!

@archangelic archangelic merged commit 0a86d69 into airbytehq:master Aug 16, 2023
33 of 37 checks passed
jbfbell pushed a commit that referenced this pull request Aug 16, 2023
Co-authored-by: Mal Hancock <mhancock@archangelic.space>
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
…#29126)

Co-authored-by: Mal Hancock <mhancock@archangelic.space>
@marcosmarxm marcosmarxm deleted the Hackathon/lowcodeFreshservices branch January 4, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/freshservice Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers
Projects
Development

Successfully merging this pull request may close these issues.

freshservice
4 participants