Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination AWS Datalake: Upgrade AWSWrangler #29221

Conversation

henriblancke
Copy link
Contributor

What

  • Upgrade awswrangler and pandas
  • Standardize type casting and type cast nested objects

How

  • Upgrade awswrangler to resolve casing sanitation issue: to_parquet lowercases column names passed in by dtype aws/aws-sdk-pandas#2357 that affects a number of sources
  • Add a standardized way to cast types to types specified in json schema. This resolves a number of issues when writing complex data types such as structs or arrays to parquet
  • Centralize constants to make code more maintainable
  • Ensure that timestamps are converted to UTC since parquet doesn't support timezone aware timestamp

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@henriblancke henriblancke changed the title Destination AWS Datalake: Upgrade AWSWrangler 🐛 Destination AWS Datalake: Upgrade AWSWrangler Aug 8, 2023
@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Aug 9, 2023
@marcosmarxm
Copy link
Member

Sorry the delay to return to you here @henriblancke right now Airbyte is hosting a hackathon (almost finishing!!!) and next week we're going to return our contribution backlog.
Thanks for the contribution as always!

@henriblancke
Copy link
Contributor Author

@marcosmarxm I appreciate the update, thanks!

@henriblancke
Copy link
Contributor Author

@marcosmarxm any rough timeline on when we can expect a review?

1 similar comment
@henriblancke
Copy link
Contributor Author

@marcosmarxm any rough timeline on when we can expect a review?

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 4:39pm

@henriblancke
Copy link
Contributor Author

@marcosmarxm any updates on a review timeline? The changes in this MR are necessary for us to get unblocked on syncing certain sources.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 25, 2023
@marcosmarxm marcosmarxm merged commit 8d60177 into airbytehq:master Oct 25, 2023
36 of 45 checks passed
@henriblancke henriblancke deleted the destination-aws-datalake-awswrangler-upgrade branch October 25, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/aws-datalake team/tse Technical Support Engineers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants