✨Source Amazon Ads: Add filter for Marketplace ID #29233

archangelic · 2023-08-08T21:39:33Z

What

Add an optional parameter to filter profiles stream by Marketplace ID

How

Add a new item to the spec to supply Marketplace IDs. Changes _choose_profiles method in source.py to filter profiles by Profile ID or Marketplace ID.

🚨 User Impact 🚨

Will add an optional spec field to add Marketplace IDs to filter profiles. Minimal impact.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Connector version is set to 0.0.1
- Dockerfile has version 0.0.1
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
- docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

github-actions · 2023-08-08T21:39:55Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

marcosmarxm

Some comments.

airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/source.py

docs/integrations/sources/amazon-ads.md

…-filter

github-actions · 2023-08-23T00:18:35Z

source-amazon-ads test report (commit `13cbe9a8c8`) - ❌

⏲️ Total pipeline duration: 51.19s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

github-actions · 2023-08-23T00:23:56Z

source-amazon-ads test report (commit `f45cb4d59b`) - ❌

⏲️ Total pipeline duration: 48.08s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

github-actions · 2023-08-23T00:27:04Z

source-amazon-ads test report (commit `2750173d10`) - ❌

⏲️ Total pipeline duration: 46.99s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

marcosmarxm

LGTM please bump the dockerfile, metadata and changelog version

archangelic · 2023-08-23T15:52:08Z

LGTM please bump the dockerfile, metadata and changelog version

Versions are already updated!

github-actions · 2023-08-23T16:41:38Z

source-amazon-ads test report (commit `7e893ccee9`) - ✅

⏲️ Total pipeline duration: 03mn23s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

github-actions · 2023-08-23T17:31:19Z

source-amazon-ads test report (commit `cc4568e82b`) - ❌

⏲️ Total pipeline duration: 02mn23s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

github-actions · 2023-08-23T18:17:22Z

source-amazon-ads test report (commit `636e77ca6a`) - ✅

⏲️ Total pipeline duration: 02mn22s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

lazebnyi

Suggested some code improvements.

airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/source.py

docs/integrations/sources/amazon-ads.md

github-actions · 2023-08-23T20:22:26Z

source-amazon-ads test report (commit `2c6c892cb8`) - ❌

⏲️ Total pipeline duration: 03mn11s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

github-actions · 2023-08-23T20:27:23Z

source-amazon-ads test report (commit `fde7e5f834`) - ✅

⏲️ Total pipeline duration: 02mn26s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/source.py

lazebnyi · 2023-08-25T10:40:19Z

Also please update PR description

Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>

github-actions · 2023-08-25T16:08:46Z

source-amazon-ads test report (commit `e2d91dc314`) - ✅

⏲️ Total pipeline duration: 03mn02s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

github-actions · 2023-08-29T12:50:43Z

source-amazon-ads test report (commit `a72f495028`) - ❌

⏲️ Total pipeline duration: 03mn09s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

github-actions · 2023-08-29T12:56:07Z

source-amazon-ads test report (commit `07b2d946a6`) - ✅

⏲️ Total pipeline duration: 03mn13s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

github-actions · 2023-08-29T13:13:24Z

source-amazon-ads test report (commit `86a8a26cea`) - ✅

⏲️ Total pipeline duration: 03mn15s

Step	Result
Connector package install	✅
Build source-amazon-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>

add marketplace id filter

9485a20

octavia-squidington-iii added area/connectors Connector related issues connectors/source/amazon-ads labels Aug 8, 2023

update docs

914c962

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 8, 2023

archangelic added the checklist-action-run label Aug 8, 2023

marcosmarxm requested changes Aug 8, 2023

View reviewed changes

airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/source.py Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/source.py Outdated Show resolved Hide resolved

docs/integrations/sources/amazon-ads.md Show resolved Hide resolved

archangelic and others added 9 commits August 8, 2023 15:10

fix filter

b38b166

update docs to include note about filters

61345de

clarify usage in spec

cdd7041

add logic to check for filter errors

d0a2524

Merge remote-tracking branch 'origin' into mal/amazon-ads-marketplace…

434d3a8

…-filter

Merge remote-tracking branch 'origin' into mal/amazon-ads-marketplace…

57b7c77

…-filter

unit test for choose profile

5706b79

add more unit tests, fix method

ce46390

fix formatting

13cbe9a

airbytehq deleted a comment from octavia-squidington-iii Aug 23, 2023

airbytehq deleted a comment from github-actions bot Aug 23, 2023

archangelic added 2 commits August 22, 2023 17:21

add one more unit test

f45cb4d

Merge branch 'master' into mal/amazon-ads-marketplace-filter

2750173

marcosmarxm approved these changes Aug 23, 2023

View reviewed changes

add mock profile for test_check

7e893cc

add more unit tests

cc4568e

fix formatting

636e77c

lazebnyi requested changes Aug 23, 2023

View reviewed changes

make changes to filtering and check

2c6c892

Merge branch 'master' into mal/amazon-ads-marketplace-filter

fde7e5f

archangelic requested a review from lazebnyi August 23, 2023 20:28

lazebnyi requested changes Aug 25, 2023

View reviewed changes

airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/source.py Outdated Show resolved Hide resolved

remove else statement

e2d91dc

Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>

archangelic requested a review from lazebnyi August 25, 2023 16:04

lazebnyi approved these changes Aug 28, 2023

View reviewed changes

marcosmarxm and others added 2 commits August 29, 2023 09:45

Merge branch 'master' into mal/amazon-ads-marketplace-filter

a72f495

bump connector version

07b2d94

Automated Commit - Formatting Changes

5929a06

Merge branch 'master' into mal/amazon-ads-marketplace-filter

86a8a26

marcosmarxm merged commit 42e407f into master Aug 29, 2023
24 checks passed

marcosmarxm deleted the mal/amazon-ads-marketplace-filter branch August 29, 2023 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨Source Amazon Ads: Add filter for Marketplace ID #29233

✨Source Amazon Ads: Add filter for Marketplace ID #29233

archangelic commented Aug 8, 2023 •

edited

github-actions bot commented Aug 8, 2023 •

edited by archangelic

marcosmarxm left a comment

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

marcosmarxm left a comment

archangelic commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

lazebnyi left a comment

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

lazebnyi commented Aug 25, 2023

github-actions bot commented Aug 25, 2023

github-actions bot commented Aug 29, 2023

github-actions bot commented Aug 29, 2023

github-actions bot commented Aug 29, 2023

✨Source Amazon Ads: Add filter for Marketplace ID #29233

✨Source Amazon Ads: Add filter for Marketplace ID #29233

Conversation

archangelic commented Aug 8, 2023 • edited

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

github-actions bot commented Aug 8, 2023 • edited by archangelic

Before Merging a Connector Pull Request

marcosmarxm left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 23, 2023

source-amazon-ads test report (commit 13cbe9a8c8) - ❌

github-actions bot commented Aug 23, 2023

source-amazon-ads test report (commit f45cb4d59b) - ❌

github-actions bot commented Aug 23, 2023

source-amazon-ads test report (commit 2750173d10) - ❌

marcosmarxm left a comment

Choose a reason for hiding this comment

archangelic commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

source-amazon-ads test report (commit 7e893ccee9) - ✅

github-actions bot commented Aug 23, 2023

source-amazon-ads test report (commit cc4568e82b) - ❌

github-actions bot commented Aug 23, 2023

source-amazon-ads test report (commit 636e77ca6a) - ✅

lazebnyi left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 23, 2023

source-amazon-ads test report (commit 2c6c892cb8) - ❌

github-actions bot commented Aug 23, 2023

source-amazon-ads test report (commit fde7e5f834) - ✅

lazebnyi commented Aug 25, 2023

github-actions bot commented Aug 25, 2023

source-amazon-ads test report (commit e2d91dc314) - ✅

github-actions bot commented Aug 29, 2023

source-amazon-ads test report (commit a72f495028) - ❌

github-actions bot commented Aug 29, 2023

source-amazon-ads test report (commit 07b2d946a6) - ✅

github-actions bot commented Aug 29, 2023

source-amazon-ads test report (commit 86a8a26cea) - ✅

archangelic commented Aug 8, 2023 •

edited

github-actions bot commented Aug 8, 2023 •

edited by archangelic

source-amazon-ads test report (commit `13cbe9a8c8`) - ❌

source-amazon-ads test report (commit `f45cb4d59b`) - ❌

source-amazon-ads test report (commit `2750173d10`) - ❌

source-amazon-ads test report (commit `7e893ccee9`) - ✅

source-amazon-ads test report (commit `cc4568e82b`) - ❌

source-amazon-ads test report (commit `636e77ca6a`) - ✅

source-amazon-ads test report (commit `2c6c892cb8`) - ❌

source-amazon-ads test report (commit `fde7e5f834`) - ✅

source-amazon-ads test report (commit `e2d91dc314`) - ✅

source-amazon-ads test report (commit `a72f495028`) - ❌

source-amazon-ads test report (commit `07b2d946a6`) - ✅

source-amazon-ads test report (commit `86a8a26cea`) - ✅