Source Hubspot: Add OwnersArchived stream #29249

arsenlosenko · 2023-08-09T12:03:12Z

What

Resolve issue described here:
#27799

How

Right now stream Owners returns records that are not archived, in order to cover this case i have added OwnersArchived stream which filters records and returns only archived records.

github-actions · 2023-08-09T12:03:34Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

octavia-squidington-iii · 2023-08-09T12:08:52Z

source-hubspot test report (commit `9e21e84bea`) - ❌

⏲️ Total pipeline duration: 01mn21s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-09T12:12:25Z

source-hubspot test report (commit `9e21e84bea`) - ❌

⏲️ Total pipeline duration: 01mn27s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-09T12:22:49Z

source-hubspot test report (commit `17ad753b39`) - ❌

⏲️ Total pipeline duration: 01mn21s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

octavia-squidington-iii · 2023-08-09T14:23:53Z

source-hubspot test report (commit `cff64785f6`) - ✅

⏲️ Total pipeline duration: 12mn04s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py

octavia-squidington-iii · 2023-08-10T11:14:11Z

source-hubspot test report (commit `987ce3de6c`) - ✅

⏲️ Total pipeline duration: 12mn04s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

airbyte-integrations/connectors/source-hubspot/acceptance-test-config.yml

…rchived-stream

octavia-squidington-iii · 2023-08-11T09:11:34Z

source-hubspot test report (commit `fad0a5aa33`) - ✅

⏲️ Total pipeline duration: 11mn26s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

…rchived-stream

octavia-squidington-iii · 2023-08-11T11:58:31Z

source-hubspot test report (commit `8abd727a51`) - ✅

⏲️ Total pipeline duration: 10mn57s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

…rchived-stream

octavia-squidington-iii · 2023-08-11T16:00:34Z

source-hubspot test report (commit `a52923bb81`) - ✅

⏲️ Total pipeline duration: 12mn08s

Step	Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-hubspot docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test

* Source Hubspot: Add OwnersArchived stream * Update changelog and CAT config * Update expected records, update schema * Update unit tests * Set archived to true explicitly

Source Hubspot: Add OwnersArchived stream

059a636

arsenlosenko self-assigned this Aug 9, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot labels Aug 9, 2023

Update changelog and CAT config

9e21e84

arsenlosenko marked this pull request as ready for review August 9, 2023 12:04

Update expected records, update schema

17ad753

Update unit tests

cff6478

arsenlosenko requested review from bazarnov and lazebnyi August 9, 2023 14:24

bazarnov approved these changes Aug 9, 2023

View reviewed changes

airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py Outdated Show resolved Hide resolved

Set archived to true explicitly

987ce3d

lazebnyi reviewed Aug 10, 2023

View reviewed changes

airbyte-integrations/connectors/source-hubspot/acceptance-test-config.yml Show resolved Hide resolved

arsenlosenko linked an issue Aug 11, 2023 that may be closed by this pull request

Source HubSpot: Missing archived owners in Hubspot connector #27799

Closed

1 task

Merge branch 'master' into arsenlosenko/27799-source-hubspot-owners-a…

fad0a5a

…rchived-stream

Merge branch 'master' into arsenlosenko/27799-source-hubspot-owners-a…

8abd727

…rchived-stream

Merge branch 'master' into arsenlosenko/27799-source-hubspot-owners-a…

a52923b

…rchived-stream

arsenlosenko merged commit 021a978 into master Aug 11, 2023
21 of 22 checks passed

arsenlosenko deleted the arsenlosenko/27799-source-hubspot-owners-archived-stream branch August 11, 2023 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Hubspot: Add OwnersArchived stream #29249

Source Hubspot: Add OwnersArchived stream #29249

arsenlosenko commented Aug 9, 2023

github-actions bot commented Aug 9, 2023 •

edited by arsenlosenko

octavia-squidington-iii commented Aug 9, 2023

octavia-squidington-iii commented Aug 9, 2023

octavia-squidington-iii commented Aug 9, 2023

octavia-squidington-iii commented Aug 9, 2023

octavia-squidington-iii commented Aug 10, 2023

octavia-squidington-iii commented Aug 11, 2023

octavia-squidington-iii commented Aug 11, 2023

octavia-squidington-iii commented Aug 11, 2023

Source Hubspot: Add OwnersArchived stream #29249

Source Hubspot: Add OwnersArchived stream #29249

Conversation

arsenlosenko commented Aug 9, 2023

What

How

github-actions bot commented Aug 9, 2023 • edited by arsenlosenko

Before Merging a Connector Pull Request

octavia-squidington-iii commented Aug 9, 2023

source-hubspot test report (commit 9e21e84bea) - ❌

octavia-squidington-iii commented Aug 9, 2023

source-hubspot test report (commit 9e21e84bea) - ❌

octavia-squidington-iii commented Aug 9, 2023

source-hubspot test report (commit 17ad753b39) - ❌

octavia-squidington-iii commented Aug 9, 2023

source-hubspot test report (commit cff64785f6) - ✅

octavia-squidington-iii commented Aug 10, 2023

source-hubspot test report (commit 987ce3de6c) - ✅

octavia-squidington-iii commented Aug 11, 2023

source-hubspot test report (commit fad0a5aa33) - ✅

octavia-squidington-iii commented Aug 11, 2023

source-hubspot test report (commit 8abd727a51) - ✅

octavia-squidington-iii commented Aug 11, 2023

source-hubspot test report (commit a52923bb81) - ✅

github-actions bot commented Aug 9, 2023 •

edited by arsenlosenko

source-hubspot test report (commit `9e21e84bea`) - ❌

source-hubspot test report (commit `9e21e84bea`) - ❌

source-hubspot test report (commit `17ad753b39`) - ❌

source-hubspot test report (commit `cff64785f6`) - ✅

source-hubspot test report (commit `987ce3de6c`) - ✅

source-hubspot test report (commit `fad0a5aa33`) - ✅

source-hubspot test report (commit `8abd727a51`) - ✅

source-hubspot test report (commit `a52923bb81`) - ✅