Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Amazon Seller Partner: attempt to fix an issue with role_arn required with authorization is done via oauth #29255

Conversation

andreyAtBB
Copy link
Contributor

What

When user creates Amazon Seller Partner connector source on Airbyte Cloud, authenticate via Oauth and save and error appears as described in these issues:
#28727
#27495

How

If role_arn is not provided (which is the case for Oauth authentication) do not attempt to split it and simply proceed.

Recommended reading order

n/a

🚨 User Impact 🚨

Should not have any impact but should allow user to proceed one step further during connector set up.

Pre-merge Actions

None

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Aug 9, 2023
@marcosmarxm marcosmarxm changed the title attempt to fix an issue with role_arn required with authorization is done via oauth Source Google Search Console: attempt to fix an issue with role_arn required with authorization is done via oauth Aug 15, 2023
@marcosmarxm marcosmarxm changed the title Source Google Search Console: attempt to fix an issue with role_arn required with authorization is done via oauth Source Amazon Seller Partner: attempt to fix an issue with role_arn required with authorization is done via oauth Aug 15, 2023
@andreyAtBB andreyAtBB changed the title Source Amazon Seller Partner: attempt to fix an issue with role_arn required with authorization is done via oauth 🐛 Source Amazon Seller Partner: attempt to fix an issue with role_arn required with authorization is done via oauth Aug 15, 2023
@rileybrook rileybrook requested review from erohmensing, marcosmarxm and lazebnyi and removed request for erohmensing August 18, 2023 18:33
@rileybrook
Copy link
Contributor

@lazebnyi Hoping this small PR can be shepherded through as it blocks an Airbtye Cloud customer from onboarding new clients.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 18, 2023
@andreyAtBB
Copy link
Contributor Author

@marcosmarxm, there are some workflows awaiting for approval from a maintainer blocking the ability to merge the fix in.
Is this something you can look at?

@marcosmarxm
Copy link
Member

@andreyAtBB I'm running tests right now to release the change.

@marcosmarxm marcosmarxm merged commit b03aac6 into airbytehq:master Aug 22, 2023
29 of 32 checks passed
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/amazon-seller-partner team/tse Technical Support Engineers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants