New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Amazon Seller Partner: attempt to fix an issue with role_arn required with authorization is done via oauth #29255
🐛 Source Amazon Seller Partner: attempt to fix an issue with role_arn required with authorization is done via oauth #29255
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@lazebnyi Hoping this small PR can be shepherded through as it blocks an Airbtye Cloud customer from onboarding new clients. |
airbyte-integrations/connectors/source-amazon-seller-partner/metadata.yaml
Show resolved
Hide resolved
@marcosmarxm, there are some workflows awaiting for approval from a maintainer blocking the ability to merge the fix in. |
@andreyAtBB I'm running tests right now to release the change. |
… required with authorization is done via oauth (airbytehq#29255)
What
When user creates Amazon Seller Partner connector source on Airbyte Cloud, authenticate via Oauth and save and error appears as described in these issues:
#28727
#27495
How
If role_arn is not provided (which is the case for Oauth authentication) do not attempt to split it and simply proceed.
Recommended reading order
n/a
🚨 User Impact 🚨
Should not have any impact but should allow user to proceed one step further during connector set up.
Pre-merge Actions
None