-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Zendesk Sunshine Source Connector to Low Code #29310
Migrate Zendesk Sunshine Source Connector to Low Code #29310
Conversation
…o zendesk-sunshine-low-code
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Hello 👋 , right now Airbyte's integration tests are failing for this connector and I'm going to work during the week to fix them. Due a high number of contributions we have a backlog and your contribution will be review next week. We ask to you share the integration test from your side whatever possible and if you don't have credentials to run tests to get in touch with @RealChrisSean as soon as possible. Also some common missing steps contributors does migrating to low code are (and you can double check to make sure you implemented this):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! In addition to the changes listed below, you will need to add a changelog entry in docs/integrations/sources/zendesk-sunshine.md
.
airbyte-integrations/connectors/source-zendesk-sunshine/metadata.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-sunshine/Dockerfile
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-sunshine/metadata.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-sunshine/source_zendesk_sunshine/manifest.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-sunshine/source_zendesk_sunshine/manifest.yaml
Show resolved
Hide resolved
…o zendesk-sunshine-low-code
…o zendesk-sunshine-low-code
Changes made @archangelic, please review |
I am running tests on this, and will let you know if there are any further changes necessary. |
This looks good now! Merging! |
Co-authored-by: Mal Hancock <mallory@archangelic.space> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
What
Migrating Source Zendesk Sunshine to Low-Code CDK resolves #28124
How
Created the connector using the connector buider UI, then imported the manifest.yaml to the low code cdk.
Recommended reading order
manifest.yaml
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.