-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
鉁⊿ource Hubplanner: Migrate Python CDK to Low-code CDK #29311
鉁⊿ource Hubplanner: Migrate Python CDK to Low-code CDK #29311
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 馃帀 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Hello 馃憢 , right now Airbyte's integration tests are failing for this connector and I'm going to work during the week to fix them. Due a high number of contributions we have a backlog and your contribution will be review next week. We ask to you share the integration test from your side whatever possible and if you don't have credentials to run tests to get in touch with @RealChrisSean as soon as possible. Also some common missing steps contributors does migrating to low code are (and you can double check to make sure you implemented this):
|
@avirajsingh7 can you give me access to your branch to push some changes? |
@marcosmarxm send you a collabrator request But stiil edit by mentors are allowed you can push to branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @avirajsingh7
/approve-and-merge reason="expired credentials, small migration and using native components" |
What
Migrating Source pipedrive to Low-Code CDK
Closes #29285
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
馃毃 User Impact 馃毃
Are there any breaking changes? What is the end result perceived by the user?
added some new properties in schema as per response from API
Test
Acceptance Test
Migrate Connector : Source Hubplanner