Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Search Console: update spec definitions #29329

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Aug 10, 2023

What

Small update to GSC spec

How

  • Minor revisions to tooltip descriptions

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-search-console labels Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@ChristoGrab ChristoGrab marked this pull request as ready for review August 10, 2023 21:23
@octavia-squidington-iii
Copy link
Collaborator

source-google-search-console test report (commit 62cb37df67) - ✅

⏲️ Total pipeline duration: 32mn41s

Step Result
Validate airbyte-integrations/connectors/source-google-search-console/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-search-console docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-search-console test

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny change request then feel free to merge

"examples": ["https://example1.com/", "sc-domain:example2.com"],
"order": 0
},
"start_date": {
"type": "string",
"title": "Start Date",
"description": "UTC date in the format 2017-01-25. Any data before this date will not be replicated.",
"description": "UTC date in the format YYYY-MM-DD. Any data before this date will not be replicated.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a pattern descriptorYYYY-MM-DD? and other props as well

@octavia-squidington-iii
Copy link
Collaborator

source-google-search-console test report (commit 3989f1424c) - ❌

⏲️ Total pipeline duration: 02mn04s

Step Result
Validate airbyte-integrations/connectors/source-google-search-console/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-search-console docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-search-console test

@octavia-squidington-iii
Copy link
Collaborator

source-google-search-console test report (commit aedfcfdc8c) - ❌

⏲️ Total pipeline duration: 02mn16s

Step Result
Validate airbyte-integrations/connectors/source-google-search-console/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-search-console docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-search-console test

@github-actions
Copy link
Contributor

source-google-search-console test report (commit 1cb605620b) - ✅

⏲️ Total pipeline duration: 37mn51s

Step Result
Connector package install
Build source-google-search-console docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-google-search-console/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-search-console test

@ChristoGrab ChristoGrab merged commit c54ec9d into master Aug 24, 2023
23 checks passed
@ChristoGrab ChristoGrab deleted the google-search-console-spec branch August 24, 2023 14:06
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-search-console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants