Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Yahoo-Finance-Price: Migrate Python CDK to No-code CDK #29355

Merged

Conversation

masyagin1998
Copy link
Contributor

What

How

  • created Yahoo-Finance-Price no-code version in Airbyte Connector Builder and then put it to new source

Recommended reading order

  • manifest.yaml

🚨 User Impact 🚨

  • no

Pre-merge Actions

  • review

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@masyagin1998
Copy link
Contributor Author

@marcosmarxm @sajarin ready for review!

@marcosmarxm marcosmarxm added team/tse Technical Support Engineers Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 labels Aug 11, 2023
@masyagin1998
Copy link
Contributor Author

Screenshot from 2023-08-12 11-16-46
Screenshot from 2023-08-12 11-17-13

After upgrading Airbyte there is one error in acceptance test connected with dagger. Except this error everything is fine.

@marcosmarxm
Copy link
Member

Hello 👋 , right now Airbyte's integration tests are failing for this connector and I'm going to work during the week to fix them. Due a high number of contributions we have a backlog and your contribution will be review next week. We ask to you share the integration test from your side whatever possible and if you don't have credentials to run tests to get in touch with @RealChrisSean as soon as possible. Also some common missing steps contributors does migrating to low code are (and you can double check to make sure you implemented this):

  • adding paginator
  • update the documentation changelog + metadata file and dockerfile version
  • if the connector has start_date parameter you must implement incremental syncs

@masyagin1998 masyagin1998 changed the title Source Yahoo-Finance-Price: Migrate Python CDK to No-code CDK ✨Source Yahoo-Finance-Price: Migrate Python CDK to No-code CDK Aug 17, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 22, 2023
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masyagin1998

@marcosmarxm marcosmarxm merged commit 76c01d6 into airbytehq:master Aug 22, 2023
44 of 49 checks passed
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/yahoo-finance-price connectors/source/yahoo-finance-price-no-code Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers
Projects
Development

Successfully merging this pull request may close these issues.

yahoo-finance-price
3 participants