New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source Yahoo-Finance-Price: Migrate Python CDK to No-code CDK #29355
✨Source Yahoo-Finance-Price: Migrate Python CDK to No-code CDK #29355
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…syagin1998/airbyte into yahoo-finance-price-no-code-connector
@marcosmarxm @sajarin ready for review! |
…syagin1998/airbyte into yahoo-finance-price-no-code-connector
Hello 👋 , right now Airbyte's integration tests are failing for this connector and I'm going to work during the week to fix them. Due a high number of contributions we have a backlog and your contribution will be review next week. We ask to you share the integration test from your side whatever possible and if you don't have credentials to run tests to get in touch with @RealChrisSean as soon as possible. Also some common missing steps contributors does migrating to low code are (and you can double check to make sure you implemented this):
|
airbyte-integrations/connectors/source-yahoo-finance-price/Dockerfile
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @masyagin1998
…tehq#29355) Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
What
How
Recommended reading order
🚨 User Impact 🚨
Pre-merge Actions