Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Sheets: added unittest, updated to latest CDK, updated docs #29491

Merged

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Aug 16, 2023

What

as part of #28213
current test coverage 77%, need > 90%

How

added unittest for source, changed setup requirements to use latest CDK, updated source docs

  • UnitTests Coverage - 91%
  • Added config error for 403 error in read()
  • Updated fields description, removed old docs, refactored documentation
  • Set latest CDK version
  • Made error messages user-friendly

@darynaishchenko darynaishchenko self-assigned this Aug 16, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-sheets labels Aug 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

docs/integrations/sources/google-sheets.md Outdated Show resolved Hide resolved
docs/integrations/sources/google-sheets.md Outdated Show resolved Hide resolved
docs/integrations/sources/google-sheets.md Outdated Show resolved Hide resolved
docs/integrations/sources/google-sheets.md Outdated Show resolved Hide resolved
docs/integrations/sources/google-sheets.md Outdated Show resolved Hide resolved
docs/integrations/sources/google-sheets.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

source-google-sheets test report (commit f570cacb00) - ❌

⏲️ Total pipeline duration: 04mn20s

Step Result
Validate airbyte-integrations/connectors/source-google-sheets/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-google-sheets docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-sheets test

@sherifnada
Copy link
Contributor

@darynaishchenko can you create an issue to remove the batch size request param? This is an implementation detail that the connector should automatically handle as part of its retry policy

@darynaishchenko
Copy link
Collaborator Author

@darynaishchenko can you create an issue to remove the batch size request param? This is an implementation detail that the connector should automatically handle as part of its retry policy

@sherifnada Sure, should this be implemented as part of the certification?

@github-actions
Copy link
Contributor

source-google-sheets test report (commit 187d47add5) - ✅

⏲️ Total pipeline duration: 02mn49s

Step Result
Connector package install
Build source-google-sheets docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-google-sheets/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-sheets test

@sherifnada
Copy link
Contributor

@darynaishchenko nope doesnt need to be part of the scope of this issue

@github-actions
Copy link
Contributor

source-google-sheets test report (commit a49bb8d30f) - ✅

⏲️ Total pipeline duration: 03mn22s

Step Result
Connector package install
Build source-google-sheets docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-google-sheets/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-sheets test

@darynaishchenko darynaishchenko merged commit 3c8301f into master Aug 23, 2023
23 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-google-sheets/increase-test-coverage branch August 23, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-sheets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants