-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Google Sheets: added unittest, updated to latest CDK, updated docs #29491
Source Google Sheets: added unittest, updated to latest CDK, updated docs #29491
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
airbyte-integrations/connectors/source-google-sheets/unit_tests/test_stream.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-google-sheets/unit_tests/test_stream.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-google-sheets/unit_tests/test_stream.py
Outdated
Show resolved
Hide resolved
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-google-sheets/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-google-sheets docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-google-sheets test
airbyte-integrations/connectors/source-google-sheets/unit_tests/test_utils.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-google-sheets/source_google_sheets/spec.yaml
Outdated
Show resolved
Hide resolved
@darynaishchenko can you create an issue to remove the batch size request param? This is an implementation detail that the connector should automatically handle as part of its retry policy |
@sherifnada Sure, should this be implemented as part of the certification? |
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-google-sheets docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/source-google-sheets/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-google-sheets test
@darynaishchenko nope doesnt need to be part of the scope of this issue |
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-google-sheets docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/source-google-sheets/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-google-sheets test
What
as part of #28213
current test coverage 77%, need > 90%
How
added unittest for source, changed setup requirements to use latest CDK, updated source docs