Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Destination Bigquery - ensure raw dataset created with migration #29522

Merged
merged 4 commits into from Aug 17, 2023
Merged

🐛 Destination Bigquery - ensure raw dataset created with migration #29522

merged 4 commits into from Aug 17, 2023

Conversation

jbfbell
Copy link
Contributor

@jbfbell jbfbell commented Aug 17, 2023 •
edited

If the raw dataset had not previously existed, we must create it for the migration

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery labels Aug 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023 •
edited by jbfbell

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@jbfbell jbfbell changed the title Destination Bigquery - ensure raw dataset created with migration 🐛 Destination Bigquery - ensure raw dataset created with migration Aug 17, 2023
@jbfbell jbfbell marked this pull request as ready for review August 17, 2023 15:23
@jbfbell jbfbell requested a review from a team as a code owner August 17, 2023 15:23
@jbfbell jbfbell enabled auto-merge (squash) August 17, 2023 15:25
evantahler
evantahler approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

.../java/io/airbyte/integrations/destination/bigquery/typing_deduping/BigQuerySqlGenerator.java
"""
CREATE SCHEMA IF NOT EXISTS ${raw_namespace}
OPTIONS(location="${dataset_location}");

CREATE OR REPLACE TABLE ${v2_raw_table} (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this table create statement also need OPTIONS(location="${dataset_location}"), or will being within the schema take care of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fairly confident that bigquery doesn't let you create tables in a different location than the dataset

.../java/io/airbyte/integrations/destination/bigquery/typing_deduping/BigQuerySqlGenerator.java
Comment on lines +614 to +615
CREATE SCHEMA IF NOT EXISTS ${raw_namespace}
OPTIONS(location="${dataset_location}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery test report (commit 271e9f288b) - ❌

⏲️ Total pipeline duration: 33mn41s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ❌
Build connector tar ✅
Build destination-bigquery docker image for platform linux/x86_64 ✅
Build airbyte/normalization:dev ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery test report (commit cc989025c4) - ❌

⏲️ Total pipeline duration: 04mn35s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml ✅
Connector version semver check ❌
Connector version increment check ❌
QA checks ✅
Build connector tar ✅
Build destination-bigquery docker image for platform linux/x86_64 ✅
Build airbyte/normalization:dev ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery test report (commit aea5db43ca) - ✅

⏲️ Total pipeline duration: 32mn36s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Build connector tar ✅
Build destination-bigquery docker image for platform linux/x86_64 ✅
Build airbyte/normalization:dev ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@jbfbell jbfbell merged commit 900645d into master Aug 17, 2023
19 checks passed
@jbfbell jbfbell deleted the joseph.bell/dataset-creation-migraiton branch August 17, 2023 16:40
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
@jbfbell @harrytou
🐛 Destination Bigquery - ensure raw dataset created with migration (a…
fa0f672 
…irbytehq#29522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbfbell @octavia-squidington-iii @evantahler