Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't check for BC entries for prerelease versions #29566

Merged
merged 3 commits into from
Aug 20, 2023
Merged

don't check for BC entries for prerelease versions #29566

merged 3 commits into from
Aug 20, 2023

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Aug 17, 2023 •
edited

What

How

  • only check for major versions, not major version pre-releases

@erohmensing erohmensing marked this pull request as ready for review August 20, 2023 21:46
@erohmensing erohmensing enabled auto-merge (squash) August 20, 2023 21:47
@erohmensing erohmensing merged commit 70a7e9a into master Aug 20, 2023
18 checks passed
@erohmensing erohmensing deleted the ella/semver branch August 20, 2023 21:47
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
@erohmensing @harrytou
don't check for BC entries for prerelease versions (airbytehq#29566)
986e245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-releases with N.0.0-dev0000000 incorrectly check for breaking change entries
2 participants
@erohmensing @evantahler