Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: Remove list endpoint #29581

Merged
merged 1 commit into from
Aug 21, 2023
Merged

CDK: Remove list endpoint #29581

merged 1 commit into from
Aug 21, 2023

Conversation

flash1293
Copy link
Contributor

Fixes #25774

The list_streams command is not required anymore, this PR is removing it.

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Aug 18, 2023
@flash1293 flash1293 marked this pull request as ready for review August 18, 2023 12:37
@flash1293 flash1293 requested a review from a team as a code owner August 18, 2023 12:37
@flash1293 flash1293 requested a review from maxi297 August 18, 2023 12:37
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. approving but naturally this will come after https://github.com/airbytehq/airbyte-platform-internal/pull/8403 presumably

@flash1293 flash1293 merged commit f8de9d1 into master Aug 21, 2023
21 checks passed
@flash1293 flash1293 deleted the flash1293/remove-list-endpoint branch August 21, 2023 10:43
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit team/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use manifest/resolve endpoint to get the list of streams instead of streams/list
3 participants