Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Mongo Internal POC: Use sampling for schema discovery #29607

Merged
merged 2 commits into from
Aug 21, 2023
Merged

🐛 Source Mongo Internal POC: Use sampling for schema discovery #29607

merged 2 commits into from
Aug 21, 2023

Conversation

jdpgrailsdev
Copy link
Contributor

What

How

  • Use $sample instead of $limit in document aggregation pipeline

Recommended reading order

  1. MongoUtil.java

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Aug 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023 •
edited by jdpgrailsdev

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@github-actions
Copy link
Contributor

source-mongodb-internal-poc test report (commit 9948d5e162) - ❌

⏲️ Total pipeline duration: 06mn07s

Step Result
Validate airbyte-integrations/connectors/source-mongodb-internal-poc/metadata.yaml ❌
Connector version semver check ✅
Connector version increment check ❌
QA checks ❌
Build connector tar ✅
Build source-mongodb-internal-poc docker image for platform linux/x86_64 ✅
./gradlew :airbyte-integrations:connectors:source-mongodb-internal-poc:integrationTest ❌
Acceptance tests ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mongodb-internal-poc test

jpefaur
jpefaur approved these changes Aug 21, 2023
View reviewed changes
...db-internal-poc/src/main/java/io/airbyte/integrations/source/mongodb/internal/MongoUtil.java
@@ -121,8 +119,7 @@ private static Set<Field> getFieldsInCollection(final MongoCollection collection
groupMap.put("fields", Map.of("$addToSet", "$fields"));

final List<Bson> aggregateList = new ArrayList<>();
aggregateList.add(Aggregates.limit(DISCOVERY_LIMIT));
sortField.ifPresent(s -> aggregateList.add(Aggregates.sort(new Document(s, -1))));
aggregateList.add(Aggregates.sample(DISCOVERY_SAMPLE_SIZE));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jdpgrailsdev
Copy link
Contributor Author

/approve-and-merge reason="mongodb source poc"

@octavia-approvington
Copy link
Contributor

Lets merge it
sheep thumbs up

@octavia-approvington octavia-approvington merged commit 5393943 into master Aug 21, 2023
23 of 27 checks passed
@octavia-approvington octavia-approvington deleted the jonathan/discovery-sample branch August 21, 2023 14:18
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
@jdpgrailsdev @harrytou
🐛 Source Mongo Internal POC: Use sampling for schema discovery (airby…
fc61f31 
…tehq#29607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpefaur jpefaur jpefaur approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdpgrailsdev @octavia-approvington @jpefaur @octavia-squidington-iii