-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: get ./gradlew format
to pass for the whole repo
#29766
Conversation
@@ -25,5 +25,4 @@ data: | |||
ab_internal: | |||
sl: 200 | |||
ql: 300 | |||
supportLevel: community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This key is duplicated and the other entry's value is certified
. Which one is correct? I did this change assuming that certified
overrides community
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in the connector report the Confluence source shows up as community
.
@postamar - I love this. Nice work. 👍 Sharing back here feedback that I sent also in DM...
|
@postamar for #2 is there are a particular issue you have with the existing formatter? I definitely agree, we need to run it for it be useful. Fwiw, the whole platform code base uses the existing formatter. It is not a hard requirement that we stay consistent across the two code bases, but I think we should default to doing that unless we have a strong reason to go in different directions. |
In principle this is the same thing as #29686 but extended to the whole repo. The purpose of this PR is twofold:
./gradlew format
#29686 (comment) for concerns about the existing style) and which isn't too different so as to not pollute the git history with more noise than necessary.In the process of (1) I found that there's not much work required to get the
format
gradle task to succeed everywhere. This surfaced a few bugs which are perhaps worth fixing.W.r.t (2) I found that https://github.com/palantir/palantir-java-format is tolerable if we tell it to conform to the Google style. This shouldn't be too surprising as it was derived from the latter originally. It's basically the same thing but with nicer handling of java-8+ lambdas. It seems to have more sophisticated rules than what's possible with the Eclipse CodeFormatter that we currently use. Styles are subjective and can be endlessly bike-shedded but I found the result to be quite nice.
The first 3 commits actually have interesting changes, the rest are mechanical.