🐛 Destination Bigquery - don't soft reset overwrite syncs #29774

jbfbell · 2023-08-23T19:59:01Z

We were attempting to soft reset final tables for overwrite syncs. We were also only creating a tempt table for overwrite syncs if the table was not empty.

This PR changes two things:

first never soft reset for overwrite syncs because the raw table might not exist and we would overwrite the soft reset at the end of the sync anyway
second, create a temp table if the table schema doesn't match for overwrite syncs, so that we are creating the proper schema and the rename replace operation at the end of the sync works successfully

github-actions · 2023-08-23T19:59:25Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

evantahler · 2023-08-23T21:31:06Z

.../main/java/io/airbyte/integrations/base/destination/typing_deduping/DefaultTyperDeduper.java

-          // overwrite an existing tmp table if needed.
-          destinationHandler.execute(sqlGenerator.createTable(stream, TMP_OVERWRITE_TABLE_SUFFIX, true));
+        if (stream.destinationSyncMode() == DestinationSyncMode.OVERWRITE) {
+          if (!destinationHandler.isFinalTableEmpty(stream.id()) || !sqlGenerator.existingSchemaMatchesStreamConfig(stream, existingTable.get())) {


It's really nice we have these helpers!

github-actions · 2023-08-23T21:59:12Z

destination-bigquery test report (commit `5a038d24b7`) - ✅

⏲️ Total pipeline duration: 34mn06s

Step	Result
Java Connector Unit Tests	✅
Build connector tar	✅
Build destination-bigquery docker image for platform linux/x86_64	✅
Build airbyte/normalization:dev	✅
Java Connector Integration Tests	✅
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

github-actions · 2023-08-23T22:31:25Z

destination-snowflake test report (commit `5a038d24b7`) - ✅

⏲️ Total pipeline duration: 32mn02s

Step	Result
Java Connector Unit Tests	✅
Build connector tar	✅
Build destination-snowflake docker image for platform linux/x86_64	✅
Build airbyte/normalization-snowflake:dev	✅
Java Connector Integration Tests	✅
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

github-actions · 2023-08-23T22:37:45Z

destination-bigquery test report (commit `b96cf0cc11`) - ❌

⏲️ Total pipeline duration: 04mn26s

Step	Result
Java Connector Unit Tests	✅
Build connector tar	✅
Build destination-bigquery docker image for platform linux/x86_64	✅
Build airbyte/normalization:dev	✅
Java Connector Integration Tests	✅
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

github-actions · 2023-08-23T23:04:19Z

destination-snowflake test report (commit `b96cf0cc11`) - ❌

⏲️ Total pipeline duration: 26mn23s

Step	Result
Java Connector Unit Tests	✅
Build connector tar	✅
Build destination-snowflake docker image for platform linux/x86_64	✅
Build airbyte/normalization-snowflake:dev	✅
Java Connector Integration Tests	❌
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

…29774)

migration fix and logging

a81efb9

octavia-squidington-iii added area/connectors Connector related issues connectors/destination/bigquery labels Aug 23, 2023

version updates

e4d7105

octavia-squidington-iii added area/documentation Improvements or additions to documentation connectors/destination/snowflake labels Aug 23, 2023

update unit tests

667ac7e

jbfbell changed the title ~~Destination Bigquery - don't soft reset overwrite syncs~~ 🐛 Destination Bigquery - don't soft reset overwrite syncs Aug 23, 2023

Merge branch 'master' into joseph.bell/migration-override-sync

5a038d2

jbfbell marked this pull request as ready for review August 23, 2023 21:22

jbfbell requested a review from a team as a code owner August 23, 2023 21:22

evantahler approved these changes Aug 23, 2023

View reviewed changes

edgao approved these changes Aug 23, 2023

View reviewed changes

jbfbell enabled auto-merge (squash) August 23, 2023 21:44

jbfbell merged commit ea3a07f into master Aug 23, 2023
29 checks passed

jbfbell deleted the joseph.bell/migration-override-sync branch August 23, 2023 22:31

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023

🐛 Destination Bigquery - don't soft reset overwrite syncs (airbytehq#…

9c5c705

…29774)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Destination Bigquery - don't soft reset overwrite syncs #29774

🐛 Destination Bigquery - don't soft reset overwrite syncs #29774

jbfbell commented Aug 23, 2023 •

edited

github-actions bot commented Aug 23, 2023 •

edited by jbfbell

evantahler Aug 23, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

🐛 Destination Bigquery - don't soft reset overwrite syncs #29774

🐛 Destination Bigquery - don't soft reset overwrite syncs #29774

Conversation

jbfbell commented Aug 23, 2023 • edited

github-actions bot commented Aug 23, 2023 • edited by jbfbell

Before Merging a Connector Pull Request

evantahler Aug 23, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 23, 2023

destination-bigquery test report (commit 5a038d24b7) - ✅

github-actions bot commented Aug 23, 2023

destination-snowflake test report (commit 5a038d24b7) - ✅

github-actions bot commented Aug 23, 2023

destination-bigquery test report (commit b96cf0cc11) - ❌

github-actions bot commented Aug 23, 2023

destination-snowflake test report (commit b96cf0cc11) - ❌

jbfbell commented Aug 23, 2023 •

edited

github-actions bot commented Aug 23, 2023 •

edited by jbfbell

destination-bigquery test report (commit `5a038d24b7`) - ✅

destination-snowflake test report (commit `5a038d24b7`) - ✅

destination-bigquery test report (commit `b96cf0cc11`) - ❌

destination-snowflake test report (commit `b96cf0cc11`) - ❌