Skip to content

πŸ› Destination Bigquery - don't soft reset overwrite syncs - #29774

Merged
Joe Bell (jbfbell) merged 4 commits into
masterfrom
joseph.bell/migration-override-sync
Aug 23, 2023
Merged

Joe Bell (jbfbell) merged 4 commits into
masterfrom
joseph.bell/migration-override-sync

Conversation

@jbfbell

@jbfbell Joe Bell (jbfbell) commented Aug 23, 2023 •

Copy link
Copy Markdown
Contributor

We were attempting to soft reset final tables for overwrite syncs. We were also only creating a tempt table for overwrite syncs if the table was not empty.

This PR changes two things:

  • first never soft reset for overwrite syncs because the raw table might not exist and we would overwrite the soft reset at the end of the sync anyway
  • second, create a temp table if the table schema doesn't match for overwrite syncs, so that we are creating the proper schema and the rename replace operation at the end of the sync works successfully

@github-actions

github-actions Bot commented Aug 23, 2023 •

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! πŸŽ‰

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@jbfbell Joe Bell (jbfbell) changed the title Destination Bigquery - don't soft reset overwrite syncs πŸ› Destination Bigquery - don't soft reset overwrite syncs Aug 23, 2023
@jbfbell
Joe Bell (jbfbell) marked this pull request as ready for review August 23, 2023 21:22
@jbfbell
Joe Bell (jbfbell) requested a review from a team as a code owner August 23, 2023 21:22
// overwrite an existing tmp table if needed.
destinationHandler.execute(sqlGenerator.createTable(stream, TMP_OVERWRITE_TABLE_SUFFIX, true));
if (stream.destinationSyncMode() == DestinationSyncMode.OVERWRITE) {
if (!destinationHandler.isFinalTableEmpty(stream.id()) || !sqlGenerator.existingSchemaMatchesStreamConfig(stream, existingTable.get())) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really nice we have these helpers!

@jbfbell
Joe Bell (jbfbell) enabled auto-merge (squash) August 23, 2023 21:44
@github-actions

Copy link
Copy Markdown
Contributor

destination-bigquery test report (commit 5a038d24b7) - βœ…

⏲️ Total pipeline duration: 34mn06s

Step Result
Java Connector Unit Tests βœ…
Build connector tar βœ…
Build destination-bigquery docker image for platform linux/x86_64 βœ…
Build airbyte/normalization:dev βœ…
Java Connector Integration Tests βœ…
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@github-actions

Copy link
Copy Markdown
Contributor

destination-snowflake test report (commit 5a038d24b7) - βœ…

⏲️ Total pipeline duration: 32mn02s

Step Result
Java Connector Unit Tests βœ…
Build connector tar βœ…
Build destination-snowflake docker image for platform linux/x86_64 βœ…
Build airbyte/normalization-snowflake:dev βœ…
Java Connector Integration Tests βœ…
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@jbfbell
Joe Bell (jbfbell) merged commit ea3a07f into master Aug 23, 2023
@jbfbell
Joe Bell (jbfbell) deleted the joseph.bell/migration-override-sync branch August 23, 2023 22:31
@github-actions

Copy link
Copy Markdown
Contributor

destination-bigquery test report (commit b96cf0cc11) - ❌

⏲️ Total pipeline duration: 04mn26s

Step Result
Java Connector Unit Tests βœ…
Build connector tar βœ…
Build destination-bigquery docker image for platform linux/x86_64 βœ…
Build airbyte/normalization:dev βœ…
Java Connector Integration Tests βœ…
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check ❌
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@github-actions

Copy link
Copy Markdown
Contributor

destination-snowflake test report (commit b96cf0cc11) - ❌

⏲️ Total pipeline duration: 26mn23s

Step Result
Java Connector Unit Tests βœ…
Build connector tar βœ…
Build destination-snowflake docker image for platform linux/x86_64 βœ…
Build airbyte/normalization-snowflake:dev βœ…
Java Connector Integration Tests ❌
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check ❌
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants