🐛Source Auth0 - Fix low code migration bugs #29804

sajarin · 2023-08-24T17:14:24Z

What

This PR aims to fix bugs introduced in the low code migration of the auth0 source connector

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Connector version is set to 0.0.1
- Dockerfile has version 0.0.1
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
- docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

github-actions · 2023-08-24T17:14:46Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions · 2023-08-24T22:17:34Z

source-auth0 test report (commit `d461deaf54`) - ❌

⏲️ Total pipeline duration: 300mn58s

Step	Result
Connector package install	✅
Build source-auth0 docker image for platform linux/x86_64	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-auth0/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

github-actions · 2023-08-25T03:20:53Z

source-auth0 test report (commit `6565337c83`) - ❌

⏲️ Total pipeline duration: 301mn00s

Step	Result
Connector package install	✅
Build source-auth0 docker image for platform linux/x86_64	✅
Acceptance tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-auth0/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

vasilisgav · 2023-08-31T12:21:34Z

Hi @sajarin, do you have an ETA on this?

sajarin · 2023-09-01T22:42:16Z

@vasilisgav trying to get this merged as soon as I can

@marcosmarxm can you take a look at the most recent commit when you get a chance, need some advice on how to properly inject the datetimecursor into the query request parameter

airbyte-integrations/connectors/source-auth0/source_auth0/manifest.yaml

github-actions · 2023-09-05T20:30:20Z

source-auth0 test report (commit `4cf8017fa4`) - ❌

⏲️ Total pipeline duration: 02mn10s

Step	Result
Connector package install	✅
Build source-auth0 docker image for platform linux/x86_64	✅
Acceptance tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-auth0/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

vercel · 2023-09-26T18:48:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 27, 2023 7:18pm

airbyte-oss-build-runner · 2023-09-26T18:53:51Z

source-auth0 test report (commit `34936df502`) - ❌

⏲️ Total pipeline duration: 02mn59s

Step	Result
Connector package install	✅
Build source-auth0 docker image for platform linux/x86_64	✅
Acceptance tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-auth0/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

airbyte-oss-build-runner · 2023-09-27T17:35:44Z

source-auth0 test report (commit `3dcb20c587`) - ❌

⏲️ Total pipeline duration: 01mn13s

Step	Result
Connector package install	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-auth0/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

airbyte-oss-build-runner · 2023-09-27T19:03:15Z

source-auth0 test report (commit `b53f452e54`) - ❌

⏲️ Total pipeline duration: 01mn07s

Step	Result
Connector package install	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-auth0/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

airbyte-oss-build-runner · 2023-09-27T19:17:33Z

source-auth0 test report (commit `5b6bb8a5a5`) - ❌

⏲️ Total pipeline duration: 02mn01s

Step	Result
Connector package install	✅
Build source-auth0 docker image for platform linux/x86_64	✅
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/source-auth0/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

airbyte-oss-build-runner · 2023-09-27T19:22:13Z

source-auth0 test report (commit `5f462011ac`) - ✅

⏲️ Total pipeline duration: 01mn57s

Step	Result
Connector package install	✅
Build source-auth0 docker image for platform linux/x86_64	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-auth0/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-auth0 test

stale

archangelic

LGTM

fix: add oauth authentication

d461dea

octavia-squidington-iii added area/connectors Connector related issues connectors/source/auth0 labels Aug 24, 2023

marcosmarxm and others added 2 commits August 24, 2023 15:03

fix custom component

7dc5992

docs: bump metadata.yml, docker files and update connector changelog

6565337

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 24, 2023

updated manifest.yaml with injected request params

345cd8d

sajarin requested a review from marcosmarxm September 1, 2023 22:40

marcosmarxm previously requested changes Sep 4, 2023

View reviewed changes

airbyte-integrations/connectors/source-auth0/source_auth0/manifest.yaml Outdated Show resolved Hide resolved

marcosmarxm reviewed Sep 4, 2023

View reviewed changes

airbyte-integrations/connectors/source-auth0/source_auth0/manifest.yaml Outdated Show resolved Hide resolved

update request parameter in manifest

4cf8017

fix: correct query request parameter for users stream

34936df

sajarin added 2 commits September 27, 2023 13:31

fix: format files, remove max_datetime and updated expected_records

4e355ec

Merge branch 'master' into saj/auth0-fix

3dcb20c

vercel bot deployed to Preview September 27, 2023 17:34 View deployment

fix: add connector base image to metadata.yaml

b53f452

fix: remove connector-acceptance-test from setup.py

5b6bb8a

Automated Commit - Formatting Changes

5f46201

archangelic approved these changes Sep 27, 2023

View reviewed changes

sajarin merged commit db7a93e into master Sep 27, 2023
29 checks passed

sajarin deleted the saj/auth0-fix branch September 27, 2023 20:47

sajarin mentioned this pull request Sep 27, 2023

Auth0 low code cdk is failing to connect and retrieve data #29789

Open

1 task

sumeetgajjar mentioned this pull request Jan 25, 2024

Auth0 connector - Connection settings with OAuth2 Confidential Application #31858

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Source Auth0 - Fix low code migration bugs #29804

🐛Source Auth0 - Fix low code migration bugs #29804

sajarin commented Aug 24, 2023

github-actions bot commented Aug 24, 2023 •

edited by sajarin

github-actions bot commented Aug 24, 2023

github-actions bot commented Aug 25, 2023

vasilisgav commented Aug 31, 2023

sajarin commented Sep 1, 2023

github-actions bot commented Sep 5, 2023

vercel bot commented Sep 26, 2023 •

edited

airbyte-oss-build-runner commented Sep 26, 2023

airbyte-oss-build-runner commented Sep 27, 2023

airbyte-oss-build-runner commented Sep 27, 2023

airbyte-oss-build-runner commented Sep 27, 2023

airbyte-oss-build-runner commented Sep 27, 2023

archangelic left a comment

🐛Source Auth0 - Fix low code migration bugs #29804

🐛Source Auth0 - Fix low code migration bugs #29804

Conversation

sajarin commented Aug 24, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

github-actions bot commented Aug 24, 2023 • edited by sajarin

Before Merging a Connector Pull Request

github-actions bot commented Aug 24, 2023

source-auth0 test report (commit d461deaf54) - ❌

github-actions bot commented Aug 25, 2023

source-auth0 test report (commit 6565337c83) - ❌

vasilisgav commented Aug 31, 2023

sajarin commented Sep 1, 2023

github-actions bot commented Sep 5, 2023

source-auth0 test report (commit 4cf8017fa4) - ❌

vercel bot commented Sep 26, 2023 • edited

airbyte-oss-build-runner commented Sep 26, 2023

source-auth0 test report (commit 34936df502) - ❌

airbyte-oss-build-runner commented Sep 27, 2023

source-auth0 test report (commit 3dcb20c587) - ❌

airbyte-oss-build-runner commented Sep 27, 2023

source-auth0 test report (commit b53f452e54) - ❌

airbyte-oss-build-runner commented Sep 27, 2023

source-auth0 test report (commit 5b6bb8a5a5) - ❌

airbyte-oss-build-runner commented Sep 27, 2023

source-auth0 test report (commit 5f462011ac) - ✅

archangelic left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 24, 2023 •

edited by sajarin

source-auth0 test report (commit `d461deaf54`) - ❌

source-auth0 test report (commit `6565337c83`) - ❌

source-auth0 test report (commit `4cf8017fa4`) - ❌

vercel bot commented Sep 26, 2023 •

edited

source-auth0 test report (commit `34936df502`) - ❌

source-auth0 test report (commit `3dcb20c587`) - ❌

source-auth0 test report (commit `b53f452e54`) - ❌

source-auth0 test report (commit `5b6bb8a5a5`) - ❌

source-auth0 test report (commit `5f462011ac`) - ✅