New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-zendesk-sell: fix phone_number type from number to string #29828 #29830
source-zendesk-sell: fix phone_number type from number to string #29828 #29830
Conversation
This patch updates the definition of the calls entity in source-zendesk
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 馃帀 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@speckm please sign the CLA.
airbyte-integrations/connectors/source-zendesk-sell/source_zendesk_sell/schemas/calls.json
Show resolved
Hide resolved
@@ -2,7 +2,7 @@ data: | |||
connectorSubtype: api | |||
connectorType: source | |||
definitionId: 982eaa4c-bba1-4cce-a971-06a41f700b8c | |||
dockerImageTag: 0.1.0 | |||
dockerImageTag: 0.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@speckm can you bump the connector doc changelog entry? After we can merge the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcosmarxm I added a changelog entry f眉r version 0.1.1.
/approve-and-merge reason="no credentials to run tests, small change" |
What
This patch updates the definition of the calls entity in source-zendesk
How
The patch updates the calls.json file of source-zendesk-sell and changes the type from number to string
馃毃 User Impact 馃毃
This change could impact users, where the target relies on the type number.