Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-zendesk-sell: fix phone_number type from number to string #29828 #29830

Conversation

speckm
Copy link
Contributor

@speckm speckm commented Aug 25, 2023

What

This patch updates the definition of the calls entity in source-zendesk

How

The patch updates the calls.json file of source-zendesk-sell and changes the type from number to string

馃毃 User Impact 馃毃

This change could impact users, where the target relies on the type number.

This patch updates the definition of the calls entity in source-zendesk
@CLAassistant
Copy link

CLAassistant commented Aug 25, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 馃帀

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@speckm speckm changed the title bugfix: source-zendesk-sell: update phone_number to string #29828 source-zendesk-sell: fix phone_number type from number to string #29828 Aug 25, 2023
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@speckm please sign the CLA.

@@ -2,7 +2,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 982eaa4c-bba1-4cce-a971-06a41f700b8c
dockerImageTag: 0.1.0
dockerImageTag: 0.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@speckm can you bump the connector doc changelog entry? After we can merge the contribution!

Copy link
Contributor Author

@speckm speckm Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcosmarxm I added a changelog entry f眉r version 0.1.1.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 30, 2023
@marcosmarxm
Copy link
Member

/approve-and-merge reason="no credentials to run tests, small change"

@octavia-approvington
Copy link
Contributor

Our work here is done
done

@octavia-approvington octavia-approvington merged commit 406ea28 into airbytehq:master Sep 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/zendesk-sell
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants