Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Apify Dataset: Migrate Python CDK to Low-code CDK #29859

Merged
merged 9 commits into from Aug 30, 2023
Merged

✨Source Apify Dataset: Migrate Python CDK to Low-code CDK #29859

merged 9 commits into from Aug 30, 2023

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented Aug 25, 2023 •
edited

What

Migrating Source Apify Dataset to Low-Code CDK
Closes #29116

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

🚨 User Impact 🚨

  • No breaking changes, migration to low-code
Migrate Connector: Source Apify Dataset

Tests

image

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/apify-dataset labels Aug 25, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@btkcodedev btkcodedev mentioned this pull request Aug 25, 2023
Closed
@btkcodedev
Copy link
Collaborator Author

Checks:
Added Paginator ✅
Added Incremental Sync ✅
Updated Version in metadata, Dockerfile and docs ✅

@marcosmarxm marcosmarxm added team/tse Technical Support Engineers Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 labels Aug 28, 2023
marcosmarxm
marcosmarxm requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

airbyte-integrations/connectors/source-apify-dataset/source_apify_dataset/spec.yaml Outdated
Comment on lines 20 to 29
start_date:
type: string
title: Start Date
description:
UTC date and time in the format 2017-01-25T00:00:00Z. Any data
before this date will not be replicated.
examples:
- "2023-08-05T00:43:59.244Z"
default: "2023-08-25T00:43:59.244Z"
airbyte_secret: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're adding a new parameter and removing another one. For the migration we must keep the same.

docs/integrations/sources/apify-dataset.md Outdated
| 0.1.0 | 2021-07-29 | [PR\#5069](https://github.com/airbytehq/airbyte/pull/5069) | Initial version of the connector |
| Version | Date | Pull Request | Subject |
| :-------- | :---------- | :------------------------------------------------------------ | :-------------------------------------------------------------------------- |
| 0.3.0 | 2023-08-25 | [TBD](https://github.com/airbytehq/airbyte/pull/TBD) | Migrate to lowcode |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this.

airbyte-integrations/connectors/source-apify-dataset/source_apify_dataset/manifest.yaml Outdated
Comment on lines 46 to 57
incremental_base:
type: DatetimeBasedCursor
cursor_field: "{{ parameters.incremental_cursor }}"
datetime_format: "%Y-%m-%dT%H:%M:%S.%f%z"
cursor_granularity: "PT0.000001S"
start_datetime:
datetime: "{{ config['start_date'] }}"
datetime_format: "%Y-%m-%dT%H:%M:%S.%f%z"
end_datetime:
datetime: "{{ today_utc() }}"
datetime_format: "%Y-%m-%d"
step: "P1M"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reference Apify documentation where you can use incremental?

airbyte-integrations/connectors/source-apify-dataset/source_apify_dataset/manifest.yaml
requester:
$ref: "#/definitions/requester"

base_paginator:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used anywhere. Please make sure to use the paginator.

@btkcodedev btkcodedev requested a review from a team as a code owner August 29, 2023 17:01
@btkcodedev
Copy link
Collaborator Author

Reolved comments, somehow my apifydataset account got disabled. Thus couldn't test the changes :(

marcosmarxm
marcosmarxm approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @btkcodedev

@marcosmarxm marcosmarxm merged commit 05b7d01 into airbytehq:master Aug 30, 2023
40 of 49 checks passed
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
@btkcodedev @marcosmarxm @harrytou
✨Source Apify Dataset: Migrate Python CDK to Low-code CDK (airbytehq#…
7e3f519 
…29859)

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/redshift connectors/destination/snowflake connectors/source/apify-dataset connectors/source/coda connectors/source/mailgun Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers
Projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apify Dataset
3 participants
@btkcodedev @marcosmarxm @octavia-squidington-iii