Modify CDC to be inline with namespace changes. #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davinchia
commented
Apr 20, 2021
| @@ -88,8 +88,10 @@ | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(CdcPostgresSourceTest.class); | |||
|
|
|||
| private static final String SLOT_NAME_BASE = "debezium_slot"; | |||
| private static final String MAKES_STREAM_NAME = "public.makes"; | |||
| private static final String MODELS_STREAM_NAME = "public.models"; | |||
| private static final String MAKES_SCHEMA = "public"; | |||
There was a problem hiding this comment.
Modified one of the tables to be in a separate schema to confirm data is propagated correctly. I think this is correct, but please sanity check my work.
|
/test connector=source-postgres
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As the title suggests.
How
Slight logic changes for make CDC in line with new namespacing expectations, namely:
I will publish the connector in a follow up PR where I'm going to publish a bunch of connectors before we release anyway.
Pre-merge Checklist
Recommended reading order
DezebiumEventUtils.java2.
DezebiumRecordPublisher.javaCdcPostgreSourceTest