New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Amazon Ads: added 404 handling for sponsored_product_ad_group_bid_recommendations… #29900
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-amazon-ads test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-amazon-ads docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-amazon-ads test
source-amazon-ads test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-amazon-ads docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/source-amazon-ads/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-amazon-ads test
…p_bid_recommendations… (airbytehq#29900)
What
resolved: https://github.com/airbytehq/oncall/issues/2536
stream failed with 404 error
How
According to doc 404 error occurs in case "404 Either the specified ad group identifier was not found, or the specified ad group was found but no associated bid was found." Stream receives groupId from parent stream, which is exists, so the problem that is specified ad group was found but no associated bid. So skipping was added for this case.