Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Stripe: prepare for the next stage certification #29950

Merged
merged 124 commits into from Sep 8, 2023

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Aug 29, 2023

What

#28206

How

  • Implement incremental deletes
  • remove "format": "date-time" from schemas as all the dates and times are unix timestamps
  • add missing expected records
  • add suggested streams
  • reduce number of required fields
  • update schemas
  • improve input config validation & unit test coverage
  • apply loockback_window_days only to streams that do not support even-based incremental syncs
  • update docs

Depends on #29330

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@github-actions
Copy link
Contributor

source-stripe test report (commit 7a02917223) - ❌

⏲️ Total pipeline duration: 09mn28s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@github-actions
Copy link
Contributor

source-stripe test report (commit 4c6f3bec70) - ❌

⏲️ Total pipeline duration: 09mn06s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

source-stripe test report (commit 739b1131c3) - ❌

⏲️ Total pipeline duration: 09mn51s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

source-stripe test report (commit fa3ca7c076) - ❌

⏲️ Total pipeline duration: 09mn48s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

source-stripe test report (commit 74ab310b30) - ❌

⏲️ Total pipeline duration: 10mn24s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

source-stripe test report (commit c2c4a38b3e) - ✅

⏲️ Total pipeline duration: 09mn45s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

source-stripe test report (commit 4e6274a501) - ❌

⏲️ Total pipeline duration: 08mn54s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

source-stripe test report (commit 59948d8a43) - ✅

⏲️ Total pipeline duration: 08mn57s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

source-stripe test report (commit fa4f428d62) - ❌

⏲️ Total pipeline duration: 48.15s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

source-stripe test report (commit 89efbe5745) - ✅

⏲️ Total pipeline duration: 11mn08s

Step Result
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@davydov-d davydov-d merged commit 2f3cb59 into master Sep 8, 2023
24 of 25 checks passed
@davydov-d davydov-d deleted the ddavydov/#28206-stripe-next-stage-certification branch September 8, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants