Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Recharge: added old api version for orders stream #29992

Merged
merged 7 commits into from
Sep 11, 2023
Merged

🐛 Source Recharge: added old api version for orders stream #29992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d3b2d8
added old api version for orders stream
darynaishchenko Aug 30, 2023
caaa472
updated changelog
darynaishchenko Aug 30, 2023
1be6c47
updated api version names
darynaishchenko Sep 4, 2023
a98b60e
Merge branch 'master' into daryna/source-recharge/oncall-2833/missing…
darynaishchenko Sep 4, 2023
8ef5395
Merge branch 'master' into daryna/source-recharge/oncall-2833/missing…
darynaishchenko Sep 5, 2023
16895f2
Automated Commit - Formatting Changes
darynaishchenko Sep 5, 2023
75d3f37
Merge branch 'master' into daryna/source-recharge/oncall-2833/missing…
darynaishchenko Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-recharge/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=1.0.0
LABEL io.airbyte.version=1.0.1
LABEL io.airbyte.name=airbyte/source-recharge
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-recharge/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 45d2e135-2ede-49e1-939f-3e3ec357a65e
dockerImageTag: 1.0.0
dockerImageTag: 1.0.1
dockerRepository: airbyte/source-recharge
githubIssueLabel: source-recharge
icon: recharge.svg
Expand Down
16 changes: 11 additions & 5 deletions airbyte-integrations/connectors/source-recharge/source_recharge/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
from airbyte_cdk.sources.streams.http import HttpStream
from airbyte_cdk.sources.utils.transform import TransformConfig, TypeTransformer

API_VERSION = "2021-11"
OLD_API_VERSION = "2021-01"
API_VERSION_2021_11 = "2021-11"
API_VERSION_2021_01 = "2021-01"


class RechargeStream(HttpStream, ABC):
Expand All @@ -38,7 +38,7 @@ def data_path(self):
def request_headers(
self, stream_state: Mapping[str, Any], stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
) -> Mapping[str, Any]:
return {"x-recharge-version": API_VERSION}
return {"x-recharge-version": API_VERSION_2021_11}

def path(
self, stream_state: Mapping[str, Any] = None, stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
Expand Down Expand Up @@ -174,8 +174,14 @@ class Onetimes(IncrementalRechargeStream):
class Orders(IncrementalRechargeStream):
"""
Orders Stream: https://developer.rechargepayments.com/v1-shopify?python#list-orders
Using old API version to avoid schema changes and loosing email, first_name, last_name columns, because in new version it not present
"""

def request_headers(
self, stream_state: Mapping[str, Any], stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
) -> Mapping[str, Any]:
return {"x-recharge-version": API_VERSION_2021_01}


class Products(RechargeStream):
"""
Expand All @@ -186,7 +192,7 @@ class Products(RechargeStream):
def request_headers(
self, stream_state: Mapping[str, Any], stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
) -> Mapping[str, Any]:
return {"x-recharge-version": OLD_API_VERSION}
return {"x-recharge-version": API_VERSION_2021_01}


class Shop(RechargeStream):
Expand All @@ -201,7 +207,7 @@ class Shop(RechargeStream):
def request_headers(
self, stream_state: Mapping[str, Any], stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
) -> Mapping[str, Any]:
return {"x-recharge-version": OLD_API_VERSION}
return {"x-recharge-version": API_VERSION_2021_01}


class Subscriptions(IncrementalRechargeStream):
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/recharge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ The Recharge connector should gracefully handle Recharge API limitations under n

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:------------------------------------------------------------------------------------------|
| 1.0.1 | 2023-08-30 | [29992](https://github.com/airbytehq/airbyte/pull/29992) | Revert for orders stream to use old API version 2021-01 |
| 1.0.0 | 2023-06-22 | [27612](https://github.com/airbytehq/airbyte/pull/27612) | Change data type of the `shopify_variant_id_not_found` field of the `Charges` stream |
| 0.2.10 | 2023-06-20 | [27503](https://github.com/airbytehq/airbyte/pull/27503) | Update API version to 2021-11 |
| 0.2.9 | 2023-04-10 | [25009](https://github.com/airbytehq/airbyte/pull/25009) | Fix owner slicing for `Metafields` stream |
Expand Down
Loading