Repository navigation
🎉 Source Facebook Marketing - remove batch processing, add user friendly config errors - #29994
Conversation
A few tweaks in spec
…iendly-config-errors
latest API allows to get all nodes with all needed fields by usual request with pagination.
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ❌ |
| Code format checks | ❌ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ❌ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ❌ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ❌ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ❌ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ❌ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ❌ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ❌ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ❌ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ❌ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
…iendly-config-errors
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ❌ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test…iendly-config-errors
…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
…iendly-config-errors
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ❌ |
| Code format checks | ❌ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ❌ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test…iendly-config-errors
…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ❌ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Integration tests | ✅ |
| Acceptance tests | ✅ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ❌ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
What
https://github.com/airbytehq/oncall/issues/1990
#24716
https://github.com/airbytehq/oncall/issues/2792
#26679
https://github.com/airbytehq/oncall/issues/2675
https://github.com/airbytehq/oncall/issues/2627
How
🚨 User Impact 🚨
No. There are updates in specs, but they happened only in spec description. So there are no breaking changes.