Skip to content

🎉 Source Facebook Marketing - remove batch processing, add user friendly config errors - #29994

Merged
midavadim merged 53 commits into
masterfrom
midavadim/24716-facebook-marketing-user-friendly-config-errors
Sep 15, 2023
Merged

midavadim merged 53 commits into
masterfrom
midavadim/24716-facebook-marketing-user-friendly-config-errors

Conversation

@midavadim

@midavadim midavadim commented Aug 30, 2023 •

Copy link
Copy Markdown
Contributor

What

https://github.com/airbytehq/oncall/issues/1990
#24716
https://github.com/airbytehq/oncall/issues/2792
#26679
https://github.com/airbytehq/oncall/issues/2675
https://github.com/airbytehq/oncall/issues/2627

How

  • updated descriptions in spec
  • added better error handling for check method
  • added better error handling raised by Facebook API, added user-friendly 'actionable' description
  • removed obsolete batch request processing which leads to "too many reguests". it was replaced by the native 'Graph API'
  • added unit tests with real Facebook API errors
  • start date is optional attribute now

🚨 User Impact 🚨

No. There are updates in specs, but they happened only in spec description. So there are no breaking changes.

latest API allows to get all nodes with all needed fields by usual request with pagination.
@github-actions

github-actions Bot commented Aug 30, 2023 •

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit 3a0d77a3d2) - ❌

⏲️ Total pipeline duration: 01mn00s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ❌
Code format checks ❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ❌
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit bbc1546046) - ❌

⏲️ Total pipeline duration: 61mn02s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ❌
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit 4f909a51b0) - ❌

⏲️ Total pipeline duration: 64mn25s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ❌
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit 16d54f6eda) - ❌

⏲️ Total pipeline duration: 66mn18s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Aug 30, 2023
@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit d982447962) - ❌

⏲️ Total pipeline duration: 50mn26s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit 912dad448e) - ✅

⏲️ Total pipeline duration: 61mn33s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions

github-actions Bot commented Sep 3, 2023

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit 831b4acb8d) - ❌

⏲️ Total pipeline duration: 06mn49s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ❌
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
@midavadim midavadim linked an issue Sep 14, 2023 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit 6099d718b1) - ❌

⏲️ Total pipeline duration: 104mn34s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅
Code format checks ❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit 526fa17969) - ✅

⏲️ Total pipeline duration: 103mn21s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit 9d575c8b0c) - ❌

⏲️ Total pipeline duration: 01mn08s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ❌
Code format checks ❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit c9f66905ea) - ❌

⏲️ Total pipeline duration: 88mn25s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅
Code format checks ❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors
@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit d22fd6062a) - ❌

⏲️ Total pipeline duration: 83mn25s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅
Code format checks ❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit 16c1ad9bef) - ✅

⏲️ Total pipeline duration: 88mn30s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@midavadim
midavadim enabled auto-merge (squash) September 15, 2023 14:00
@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit eb748a7a63) - ✅

⏲️ Total pipeline duration: 88mn11s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@midavadim
midavadim merged commit 17fad7d into master Sep 15, 2023
@midavadim
midavadim deleted the midavadim/24716-facebook-marketing-user-friendly-config-errors branch September 15, 2023 15:30
@github-actions

Copy link
Copy Markdown
Contributor

source-facebook-marketing test report (commit e006f93b33) - ❌

⏲️ Total pipeline duration: 91mn26s

Step Result
Connector package install ✅
Build source-facebook-marketing docker image for platform linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅
Code format checks ✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ❌
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing

Projects

None yet

3 participants