🎉 Source Facebook Marketing - remove batch processing, add user friendly config errors #29994

midavadim · 2023-08-30T13:57:38Z

What

https://github.com/airbytehq/oncall/issues/1990
#24716
https://github.com/airbytehq/oncall/issues/2792
#26679
https://github.com/airbytehq/oncall/issues/2675
https://github.com/airbytehq/oncall/issues/2627

How

updated descriptions in spec
added better error handling for check method
added better error handling raised by Facebook API, added user-friendly 'actionable' description
removed obsolete batch request processing which leads to "too many reguests". it was replaced by the native 'Graph API'
added unit tests with real Facebook API errors
start date is optional attribute now

🚨 User Impact 🚨

No. There are updates in specs, but they happened only in spec description. So there are no breaking changes.

A few tweaks in spec

…iendly-config-errors

latest API allows to get all nodes with all needed fields by usual request with pagination.

github-actions · 2023-08-30T13:58:03Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions · 2023-08-30T14:00:20Z

source-facebook-marketing test report (commit `3a0d77a3d2`) - ❌

⏲️ Total pipeline duration: 01mn00s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

github-actions · 2023-08-30T16:14:56Z

source-facebook-marketing test report (commit `bbc1546046`) - ❌

⏲️ Total pipeline duration: 61mn02s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

github-actions · 2023-08-30T17:24:44Z

source-facebook-marketing test report (commit `4f909a51b0`) - ❌

⏲️ Total pipeline duration: 64mn25s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

github-actions · 2023-08-30T18:47:21Z

source-facebook-marketing test report (commit `16d54f6eda`) - ❌

⏲️ Total pipeline duration: 66mn18s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

…iendly-config-errors

github-actions · 2023-08-30T20:25:24Z

source-facebook-marketing test report (commit `d982447962`) - ❌

⏲️ Total pipeline duration: 50mn26s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

github-actions · 2023-08-31T14:28:58Z

source-facebook-marketing test report (commit `912dad448e`) - ✅

⏲️ Total pipeline duration: 61mn33s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

github-actions · 2023-09-03T14:16:20Z

source-facebook-marketing test report (commit `831b4acb8d`) - ❌

⏲️ Total pipeline duration: 06mn49s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

…iendly-config-errors

github-actions · 2023-09-14T15:59:20Z

source-facebook-marketing test report (commit `6099d718b1`) - ❌

⏲️ Total pipeline duration: 104mn34s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…iendly-config-errors

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

…iendly-config-errors

github-actions · 2023-09-14T17:44:39Z

source-facebook-marketing test report (commit `526fa17969`) - ✅

⏲️ Total pipeline duration: 103mn21s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

github-actions · 2023-09-14T17:48:03Z

source-facebook-marketing test report (commit `9d575c8b0c`) - ❌

⏲️ Total pipeline duration: 01mn08s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

github-actions · 2023-09-14T21:00:52Z

source-facebook-marketing test report (commit `c9f66905ea`) - ❌

⏲️ Total pipeline duration: 88mn25s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

…iendly-config-errors

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

github-actions · 2023-09-15T10:23:04Z

source-facebook-marketing test report (commit `d22fd6062a`) - ❌

⏲️ Total pipeline duration: 83mn25s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	❌
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

github-actions · 2023-09-15T11:53:21Z

source-facebook-marketing test report (commit `16c1ad9bef`) - ✅

⏲️ Total pipeline duration: 88mn30s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/source.py

…iendly-config-errors

github-actions · 2023-09-15T15:30:05Z

source-facebook-marketing test report (commit `eb748a7a63`) - ✅

⏲️ Total pipeline duration: 88mn11s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

github-actions · 2023-09-15T17:03:51Z

source-facebook-marketing test report (commit `e006f93b33`) - ❌

⏲️ Total pipeline duration: 91mn26s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

midavadim added 3 commits August 30, 2023 15:21

catch all errors for check method and show user friendly message

47b70ca

A few tweaks in spec

Merge branch 'master' into midavadim/24716-facebook-marketing-user-fr…

0aa0d03

…iendly-config-errors

removed batch processing because it is not needed anymore.

3a0d77a

latest API allows to get all nodes with all needed fields by usual request with pagination.

octavia-squidington-iii added area/connectors Connector related issues connectors/source/facebook-marketing labels Aug 30, 2023

midavadim and others added 3 commits August 30, 2023 14:01

Automated Commit - Formatting Changes

94e4fef

updated unit test, updated formating, removed not needed imports

a504eba

Merge remote-tracking branch 'origin/midavadim/24716-facebook-marketi…

bbc1546

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

midavadim added 2 commits August 30, 2023 19:16

updated SAT

3774b32

updated SAT

4f909a5

midavadim and others added 2 commits August 30, 2023 20:38

updated version and spec

16d54f6

Automated Commit - Formatting Changes

9b98d79

midavadim added 2 commits August 30, 2023 22:32

added change history

f709cab

Merge remote-tracking branch 'origin/midavadim/24716-facebook-marketi…

d982447

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 30, 2023

midavadim added 2 commits August 30, 2023 23:09

Merge branch 'master' of https://github.com/airbytehq/airbyte

c0e2f33

Merge branch 'master' into midavadim/24716-facebook-marketing-user-fr…

3758565

…iendly-config-errors

updated SAT

912dad4

midavadim and others added 2 commits September 3, 2023 17:07

added better error handling

831b4ac

Automated Commit - Formatting Changes

3db625b

midavadim added 2 commits September 3, 2023 23:54

updated SAT

2863f3f

Merge remote-tracking branch 'origin/midavadim/24716-facebook-marketi…

944245c

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

midavadim added 2 commits September 14, 2023 18:10

Merge remote-tracking branch 'origin/midavadim/24716-facebook-marketi…

f6fc7b9

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

Merge branch 'master' into midavadim/24716-facebook-marketing-user-fr…

526fa17

…iendly-config-errors

midavadim linked an issue Sep 14, 2023 that may be closed by this pull request

[EPIC] Source Facebook Marketing to Silver #28208

Closed

midavadim added 5 commits September 14, 2023 19:50

Merge branch 'master' of https://github.com/airbytehq/airbyte

50906ac

Merge branch 'master' into midavadim/24716-facebook-marketing-user-fr…

124fe18

…iendly-config-errors

format

bb2771d

Merge remote-tracking branch 'origin/midavadim/24716-facebook-marketi…

3bff8dd

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

Merge branch 'master' into midavadim/24716-facebook-marketing-user-fr…

9d575c8

…iendly-config-errors

midavadim added 2 commits September 14, 2023 22:30

format

22e5713

Merge remote-tracking branch 'origin/midavadim/24716-facebook-marketi…

c9f6690

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

midavadim added 3 commits September 15, 2023 11:57

Merge branch 'master' into midavadim/24716-facebook-marketing-user-fr…

d22fd60

…iendly-config-errors

format

b83484c

Merge remote-tracking branch 'origin/midavadim/24716-facebook-marketi…

16c1ad9

…ng-user-friendly-config-errors' into midavadim/24716-facebook-marketing-user-friendly-config-errors

lazebnyi approved these changes Sep 15, 2023

View reviewed changes

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/source.py Show resolved Hide resolved

midavadim added 2 commits September 15, 2023 16:59

updated error messages

21d2aa5

Merge branch 'master' into midavadim/24716-facebook-marketing-user-fr…

eb748a7

…iendly-config-errors

midavadim enabled auto-merge (squash) September 15, 2023 14:00

midavadim merged commit 17fad7d into master Sep 15, 2023
21 of 22 checks passed

midavadim deleted the midavadim/24716-facebook-marketing-user-friendly-config-errors branch September 15, 2023 15:30

This was referenced Sep 15, 2023

Fetch facebook marketing source in small batches #9593

Closed

🐛 Source Facebook Marketing: There have been too many calls to this ad-account. #8773

Closed

ChristoGrab mentioned this pull request Oct 4, 2023

Source Facebook Marketing: start date is required #23068

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Facebook Marketing - remove batch processing, add user friendly config errors #29994

🎉 Source Facebook Marketing - remove batch processing, add user friendly config errors #29994

midavadim commented Aug 30, 2023 •

edited

github-actions bot commented Aug 30, 2023 •

edited by midavadim

github-actions bot commented Aug 30, 2023

github-actions bot commented Aug 30, 2023

github-actions bot commented Aug 30, 2023

github-actions bot commented Aug 30, 2023

github-actions bot commented Aug 30, 2023

github-actions bot commented Aug 31, 2023

github-actions bot commented Sep 3, 2023

github-actions bot commented Sep 14, 2023

github-actions bot commented Sep 14, 2023

github-actions bot commented Sep 14, 2023

github-actions bot commented Sep 14, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

🎉 Source Facebook Marketing - remove batch processing, add user friendly config errors #29994

🎉 Source Facebook Marketing - remove batch processing, add user friendly config errors #29994

Conversation

midavadim commented Aug 30, 2023 • edited

What

How

🚨 User Impact 🚨

github-actions bot commented Aug 30, 2023 • edited by midavadim

Before Merging a Connector Pull Request

github-actions bot commented Aug 30, 2023

source-facebook-marketing test report (commit 3a0d77a3d2) - ❌

github-actions bot commented Aug 30, 2023

source-facebook-marketing test report (commit bbc1546046) - ❌

github-actions bot commented Aug 30, 2023

source-facebook-marketing test report (commit 4f909a51b0) - ❌

github-actions bot commented Aug 30, 2023

source-facebook-marketing test report (commit 16d54f6eda) - ❌

github-actions bot commented Aug 30, 2023

source-facebook-marketing test report (commit d982447962) - ❌

github-actions bot commented Aug 31, 2023

source-facebook-marketing test report (commit 912dad448e) - ✅

github-actions bot commented Sep 3, 2023

source-facebook-marketing test report (commit 831b4acb8d) - ❌

github-actions bot commented Sep 14, 2023

source-facebook-marketing test report (commit 6099d718b1) - ❌

github-actions bot commented Sep 14, 2023

source-facebook-marketing test report (commit 526fa17969) - ✅

github-actions bot commented Sep 14, 2023

source-facebook-marketing test report (commit 9d575c8b0c) - ❌

github-actions bot commented Sep 14, 2023

source-facebook-marketing test report (commit c9f66905ea) - ❌

github-actions bot commented Sep 15, 2023

source-facebook-marketing test report (commit d22fd6062a) - ❌

github-actions bot commented Sep 15, 2023

source-facebook-marketing test report (commit 16c1ad9bef) - ✅

github-actions bot commented Sep 15, 2023

source-facebook-marketing test report (commit eb748a7a63) - ✅

github-actions bot commented Sep 15, 2023

source-facebook-marketing test report (commit e006f93b33) - ❌

midavadim commented Aug 30, 2023 •

edited

github-actions bot commented Aug 30, 2023 •

edited by midavadim

source-facebook-marketing test report (commit `3a0d77a3d2`) - ❌

source-facebook-marketing test report (commit `bbc1546046`) - ❌

source-facebook-marketing test report (commit `4f909a51b0`) - ❌

source-facebook-marketing test report (commit `16d54f6eda`) - ❌

source-facebook-marketing test report (commit `d982447962`) - ❌

source-facebook-marketing test report (commit `912dad448e`) - ✅

source-facebook-marketing test report (commit `831b4acb8d`) - ❌

source-facebook-marketing test report (commit `6099d718b1`) - ❌

source-facebook-marketing test report (commit `526fa17969`) - ✅

source-facebook-marketing test report (commit `9d575c8b0c`) - ❌

source-facebook-marketing test report (commit `c9f66905ea`) - ❌

source-facebook-marketing test report (commit `d22fd6062a`) - ❌

source-facebook-marketing test report (commit `16c1ad9bef`) - ✅

source-facebook-marketing test report (commit `eb748a7a63`) - ✅

source-facebook-marketing test report (commit `e006f93b33`) - ❌