Source Zendesk Support: handle Non JSON Response #30142

artem1205 · 2023-09-04T17:23:05Z

What

Resolve

How

gracefully handle Non JSON Response

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

github-actions · 2023-09-04T17:23:28Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

…n-json-response

…-handle-non-json-response' into artem1205/source-zendesk-support-handle-non-json-response

This reverts commit 6ed1a8d.

This reverts commit 9fe245d.

github-actions · 2023-09-05T12:22:38Z

source-zendesk-support test report (commit `5cad5f0480`) - ❌

⏲️ Total pipeline duration: 11mn48s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

…-handle-non-json-response' into artem1205/source-zendesk-support-handle-non-json-response

github-actions · 2023-09-05T12:35:20Z

source-zendesk-support test report (commit `d41a42f610`) - ❌

⏲️ Total pipeline duration: 10mn49s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

github-actions · 2023-09-05T12:42:15Z

source-zendesk-support test report (commit `b9c7016446`) - ✅

⏲️ Total pipeline duration: 05mn01s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

…n-json-response

github-actions · 2023-09-07T10:00:50Z

source-zendesk-support test report (commit `099114ad20`) - ❌

⏲️ Total pipeline duration: 07mn49s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

github-actions · 2023-09-07T10:52:39Z

source-zendesk-support test report (commit `e8eeef5b46`) - ❌

⏲️ Total pipeline duration: 06mn52s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

…n-json-response

github-actions · 2023-09-07T12:38:24Z

source-zendesk-support test report (commit `aeb463aa5a`) - ❌

⏲️ Total pipeline duration: 03mn09s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

…-handle-non-json-response' into artem1205/source-zendesk-support-handle-non-json-response

github-actions · 2023-09-07T15:39:06Z

source-zendesk-support test report (commit `14954b080c`) - ✅

⏲️ Total pipeline duration: 08mn44s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py

github-actions · 2023-09-08T12:36:26Z

source-zendesk-support test report (commit `0a5dd3eb26`) - ❌

⏲️ Total pipeline duration: 09mn26s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

github-actions · 2023-09-08T12:54:09Z

source-zendesk-support test report (commit `432ea38c5f`) - ✅

⏲️ Total pipeline duration: 08mn50s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

Source Zendesk Support: handle Non JSON Response

4f779e7

octavia-squidington-iii added area/connectors Connector related issues connectors/source/zendesk-support labels Sep 4, 2023

artem1205 and others added 5 commits September 4, 2023 17:26

Automated Commit - Formatting Changes

6dac59e

Merge branch 'master' into artem1205/source-zendesk-support-handle-no…

c1a9e28

…n-json-response

Source Zendesk Support: update docs

45adbcf

Automated Commit - Formatting Changes

6ed1a8d

Merge remote-tracking branch 'origin/artem1205/source-zendesk-support…

4076964

…-handle-non-json-response' into artem1205/source-zendesk-support-handle-non-json-response

artem1205 self-assigned this Sep 5, 2023

Revert "Automated Commit - Formatting Changes"

0bad99c

This reverts commit 6ed1a8d.

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 5, 2023

artem1205 requested review from lazebnyi and darynaishchenko September 5, 2023 11:17

artem1205 and others added 3 commits September 5, 2023 11:26

Automated Commit - Formatting Changes

9fe245d

Source Zendesk Support: update docs

4f59fd8

Revert "Automated Commit - Formatting Changes"

5cad5f0

This reverts commit 9fe245d.

octavia-squidington-iii added the connectors/source/hubplanner label Sep 5, 2023

artem1205 marked this pull request as ready for review September 5, 2023 12:08

artem1205 force-pushed the artem1205/source-zendesk-support-handle-non-json-response branch from 3bfbae0 to 5cad5f0 Compare September 5, 2023 12:08

Automated Commit - Formatting Changes

d41a42f

artem1205 added 2 commits September 5, 2023 14:26

Source Zendesk Support: update expected records

62d725e

Merge remote-tracking branch 'origin/artem1205/source-zendesk-support…

b9c7016

…-handle-non-json-response' into artem1205/source-zendesk-support-handle-non-json-response

Merge branch 'master' into artem1205/source-zendesk-support-handle-no…

099114a

…n-json-response

airbytehq deleted a comment from github-actions bot Sep 7, 2023

Source Zendesk Support: update expected records

e8eeef5

Merge branch 'master' into artem1205/source-zendesk-support-handle-no…

aeb463a

…n-json-response

artem1205 added 2 commits September 7, 2023 17:27

Source Zendesk Support: fix incremental catalog for tests

da1fb9e

Merge remote-tracking branch 'origin/artem1205/source-zendesk-support…

14954b0

…-handle-non-json-response' into artem1205/source-zendesk-support-handle-non-json-response

darynaishchenko reviewed Sep 8, 2023

View reviewed changes

airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py Show resolved Hide resolved

darynaishchenko approved these changes Sep 8, 2023

View reviewed changes

Source Zendesk Support: add unit test

0a5dd3e

Source Zendesk Support: update expected recrods

432ea38

artem1205 merged commit 31264d0 into master Sep 8, 2023
24 checks passed

artem1205 deleted the artem1205/source-zendesk-support-handle-non-json-response branch September 8, 2023 13:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Zendesk Support: handle Non JSON Response #30142

Source Zendesk Support: handle Non JSON Response #30142

artem1205 commented Sep 4, 2023 •

edited

Loading

github-actions bot commented Sep 4, 2023 •

edited by artem1205

Loading

github-actions bot commented Sep 5, 2023

github-actions bot commented Sep 5, 2023

github-actions bot commented Sep 5, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 8, 2023

github-actions bot commented Sep 8, 2023

Source Zendesk Support: handle Non JSON Response #30142

Source Zendesk Support: handle Non JSON Response #30142

Conversation

artem1205 commented Sep 4, 2023 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

github-actions bot commented Sep 4, 2023 • edited by artem1205 Loading

Before Merging a Connector Pull Request

github-actions bot commented Sep 5, 2023

source-zendesk-support test report (commit 5cad5f0480) - ❌

github-actions bot commented Sep 5, 2023

source-zendesk-support test report (commit d41a42f610) - ❌

github-actions bot commented Sep 5, 2023

source-zendesk-support test report (commit b9c7016446) - ✅

github-actions bot commented Sep 7, 2023

source-zendesk-support test report (commit 099114ad20) - ❌

github-actions bot commented Sep 7, 2023

source-zendesk-support test report (commit e8eeef5b46) - ❌

github-actions bot commented Sep 7, 2023

source-zendesk-support test report (commit aeb463aa5a) - ❌

github-actions bot commented Sep 7, 2023

source-zendesk-support test report (commit 14954b080c) - ✅

github-actions bot commented Sep 8, 2023

source-zendesk-support test report (commit 0a5dd3eb26) - ❌

github-actions bot commented Sep 8, 2023

source-zendesk-support test report (commit 432ea38c5f) - ✅

artem1205 commented Sep 4, 2023 •

edited

Loading

github-actions bot commented Sep 4, 2023 •

edited by artem1205

Loading

source-zendesk-support test report (commit `5cad5f0480`) - ❌

source-zendesk-support test report (commit `d41a42f610`) - ❌

source-zendesk-support test report (commit `b9c7016446`) - ✅

source-zendesk-support test report (commit `099114ad20`) - ❌

source-zendesk-support test report (commit `e8eeef5b46`) - ❌

source-zendesk-support test report (commit `aeb463aa5a`) - ❌

source-zendesk-support test report (commit `14954b080c`) - ✅

source-zendesk-support test report (commit `0a5dd3eb26`) - ❌

source-zendesk-support test report (commit `432ea38c5f`) - ✅