-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-hosted EC2 Runners #3019
Self-hosted EC2 Runners #3019
Conversation
A single approval is sufficient. Tagging everyone so people are aware of what is going on. Not merging this in until our request to increase our AWS vCPU limit is approved. |
with: | ||
mode: start | ||
github-token: ${{ secrets.SELF_RUNNER_GITHUB_ACCESS_TOKEN }} | ||
ec2-image-id: ami-0b39c2b1b65f75ca8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are all resources living in the aws dev account.
only comment is that the checks are pretty muddled. (checkmark per start and stop) Can we just make starting the runner a step in the build? |
Our limit got increased to 160 vCPU, which means we might run into issues if too many builds are triggered at once. AWS says we can request another limit increase when this happens. @sherifnada I looked into trying to clean this up; I don't think it's straightforward since the all steps of a job need to run on the same instance. The start/stop jobs are on Github's instance, while the build steps aren't. Will merge for now and look into this if other people find this annoying. |
What
Use self-hosted ec2 runners for the main Airbyte build as discussed today. Will bring this up for evaluation after a week. Anecdotal testing shows builds generally finish in 9 - 10 mins vs 15 - 20 mins on the regular runner, even after accounting for the time taken to spin up the instance (about 1 min).
Removed this from the frontend tests since Cypress is running into an issue that seems to be related to how the tests are structured and I don't think we need to debug now.
The slash commands will continue running on the github runner.
How
1000 USD / 0.34 USD * 60 mins ~= 177k mins/month
of build time.Recommended reading order