Source Zendesk Support: add stream `Deleted Tickets` #30259

artem1205 · 2023-09-07T18:08:01Z

What

add new stream Deleted Tickets

How

add new stream Deleted Tickets

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

github-actions · 2023-09-07T18:08:24Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

…ndesk-support-add-deleted # Conflicts: # airbyte-integrations/connectors/source-zendesk-support/integration_tests/expected_records.jsonl

github-actions · 2023-09-11T10:06:10Z

source-zendesk-support test report (commit `935103011f`) - ❌

⏲️ Total pipeline duration: 09mn17s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

github-actions · 2023-09-11T10:19:34Z

source-zendesk-support test report (commit `48e8372a29`) - ❌

⏲️ Total pipeline duration: 01mn04s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	❌
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

github-actions · 2023-09-11T10:40:43Z

source-zendesk-support test report (commit `16e9bd8dd9`) - ✅

⏲️ Total pipeline duration: 08mn49s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

github-actions · 2023-09-11T12:30:19Z

source-zendesk-support test report (commit `5a4dedd565`) - ✅

⏲️ Total pipeline duration: 08mn24s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/source.py

…zendesk_support/source.py Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>

github-actions · 2023-09-11T16:07:40Z

source-zendesk-support test report (commit `20ff186087`) - ✅

⏲️ Total pipeline duration: 08mn58s

Step	Result
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

artem1205 added 2 commits September 7, 2023 19:55

Source Zendesk Support: add deleted tickets stream

ecf0b5a

Source Zendesk Support: update docs

85cd3af

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support labels Sep 7, 2023

Source Zendesk Support: update expected records

fdd7aaf

artem1205 self-assigned this Sep 7, 2023

artem1205 added 5 commits September 8, 2023 13:24

Source Zendesk Support: ref text error message

6b36b45

Source Zendesk Support: refactor error messages

25918e2

Source Zendesk Support: ref

c9903cc

Merge remote-tracking branch 'origin/master' into artem1205/source-ze…

f036a62

…ndesk-support-add-deleted # Conflicts: # airbyte-integrations/connectors/source-zendesk-support/integration_tests/expected_records.jsonl

Source Zendesk Support: update docs

9351030

artem1205 marked this pull request as ready for review September 11, 2023 09:55

Source Zendesk Support: reformat

48e8372

airbytehq deleted a comment from github-actions bot Sep 11, 2023

artem1205 added 2 commits September 11, 2023 12:23

Source Zendesk Support: reformat

a9e4019

Source Zendesk Support: rev test

16e9bd8

artem1205 requested review from lazebnyi and darynaishchenko September 11, 2023 10:42

Source Zendesk Support: update error message

5a4dedd

lazebnyi approved these changes Sep 11, 2023

View reviewed changes

airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/source.py Outdated Show resolved Hide resolved

Update airbyte-integrations/connectors/source-zendesk-support/source_…

20ff186

…zendesk_support/source.py Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>

artem1205 merged commit 626333e into master Sep 11, 2023
24 checks passed

artem1205 deleted the artem1205/source-zendesk-support-add-deleted branch September 11, 2023 19:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Zendesk Support: add stream `Deleted Tickets` #30259

Source Zendesk Support: add stream `Deleted Tickets` #30259

artem1205 commented Sep 7, 2023

github-actions bot commented Sep 7, 2023 •

edited by artem1205

Loading

github-actions bot commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

Source Zendesk Support: add stream Deleted Tickets #30259

Source Zendesk Support: add stream Deleted Tickets #30259

Conversation

artem1205 commented Sep 7, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

github-actions bot commented Sep 7, 2023 • edited by artem1205 Loading

Before Merging a Connector Pull Request

github-actions bot commented Sep 11, 2023

source-zendesk-support test report (commit 935103011f) - ❌

github-actions bot commented Sep 11, 2023

source-zendesk-support test report (commit 48e8372a29) - ❌

github-actions bot commented Sep 11, 2023

source-zendesk-support test report (commit 16e9bd8dd9) - ✅

github-actions bot commented Sep 11, 2023

source-zendesk-support test report (commit 5a4dedd565) - ✅

github-actions bot commented Sep 11, 2023

source-zendesk-support test report (commit 20ff186087) - ✅

Source Zendesk Support: add stream `Deleted Tickets` #30259

Source Zendesk Support: add stream `Deleted Tickets` #30259

github-actions bot commented Sep 7, 2023 •

edited by artem1205

Loading

source-zendesk-support test report (commit `935103011f`) - ❌

source-zendesk-support test report (commit `48e8372a29`) - ❌

source-zendesk-support test report (commit `16e9bd8dd9`) - ✅

source-zendesk-support test report (commit `5a4dedd565`) - ✅

source-zendesk-support test report (commit `20ff186087`) - ✅