Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Mixpanel: Add default primary key to export stream #30469

Merged
merged 2 commits into from Sep 15, 2023

Conversation

bazarnov
Copy link
Collaborator

What

Resolving: https://github.com/airbytehq/oncall/issues/2939

How

🚨 User Impact 🚨

Not a breaking change.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Sep 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@bazarnov bazarnov self-assigned this Sep 15, 2023
@bazarnov bazarnov marked this pull request as ready for review September 15, 2023 11:17
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 15, 2023
@github-actions
Copy link
Contributor

source-mixpanel test report (commit 472fc2355a) - ✅

⏲️ Total pipeline duration: 194mn42s

Step Result
Connector package install
Build source-mixpanel docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-mixpanel/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mixpanel test

@bazarnov bazarnov enabled auto-merge (squash) September 15, 2023 14:40
@github-actions
Copy link
Contributor

source-mixpanel test report (commit 472fc2355a) - ✅

⏲️ Total pipeline duration: 67mn01s

Step Result
Connector package install
Build source-mixpanel docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-mixpanel/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mixpanel test

@bazarnov bazarnov merged commit 3c7a112 into master Sep 15, 2023
28 checks passed
@bazarnov bazarnov deleted the baz/source-mixpanel/add-pk-to-export-stream branch September 15, 2023 15:43
@grkhr
Copy link
Contributor

grkhr commented Sep 26, 2023

This could be wrong. distinct_id is a kind of user id. Unique key of the event (which is the entity of export) is the insert_id.

@bazarnov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mixpanel
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

5 participants