Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source S3: remove streams.*.file_type from source-s3 configuration #30476

Merged
merged 4 commits into from Sep 18, 2023

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Sep 15, 2023

What

Follow-up to #30453 to address #30353

How

Update legacy config transformer, tests and document breaking change.

🚨 User Impact 🚨

As mentioned in the documentation, this change is only breaking if the user created S3 sources using the API and did not provide streams.*.format.

@maxi297 maxi297 requested a review from clnoll September 15, 2023 14:34
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3 labels Sep 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! πŸŽ‰

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@github-actions
Copy link
Contributor

source-s3 test report (commit afddd00c84) - ❌

⏲️ Total pipeline duration: 01mn04s

Step Result
Connector package install ❌
Code format checks βœ…
Validate airbyte-integrations/connectors/source-s3/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check ❌
QA checks ❌

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@maxi297
Copy link
Contributor Author

maxi297 commented Sep 15, 2023

Failure is expected at this point as the new CDK version hasn't been released

@maxi297 maxi297 changed the title [ISSUE #30353] remove from source-s3 and make required ✨ Source S3: remove streams.*.file_type from source-s3 configuration Sep 15, 2023
@github-actions
Copy link
Contributor

source-s3 test report (commit 4530195696) - ❌

⏲️ Total pipeline duration: 01mn07s

Step Result
Connector package install ❌
Code format checks βœ…
Validate airbyte-integrations/connectors/source-s3/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks ❌

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

source-s3 test report (commit 4f175af9ec) - ❌

⏲️ Total pipeline duration: 09mn39s

Step Result
Connector package install βœ…
Build source-s3 docker image for platform linux/x86_64 βœ…
Unit tests βœ…
Acceptance tests βœ…
Code format checks βœ…
Validate airbyte-integrations/connectors/source-s3/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks ❌

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@github-actions
Copy link
Contributor

source-s3 test report (commit 1f7b84ed7a) - βœ…

⏲️ Total pipeline duration: 04mn00s

Step Result
Connector package install βœ…
Build source-s3 docker image for platform linux/x86_64 βœ…
Unit tests βœ…
Acceptance tests βœ…
Code format checks βœ…
Validate airbyte-integrations/connectors/source-s3/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@maxi297 maxi297 merged commit 2954cbb into master Sep 18, 2023
24 checks passed
@maxi297 maxi297 deleted the issue-30353/update-source-s3 branch September 18, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants