New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ Source S3: remove streams.*.file_type
from source-s3 configuration
#30476
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! π To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-s3 test report (commit
|
Step | Result |
---|---|
Connector package install | β |
Code format checks | β |
Validate airbyte-integrations/connectors/source-s3/metadata.yaml | β |
Connector version semver check | β |
Connector version increment check | β |
QA checks | β |
π View the logs here
βοΈ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-s3 test
Failure is expected at this point as the new CDK version hasn't been released |
streams.*.file_type
from source-s3 configuration
source-s3 test report (commit
|
Step | Result |
---|---|
Connector package install | β |
Code format checks | β |
Validate airbyte-integrations/connectors/source-s3/metadata.yaml | β |
Connector version semver check | β |
Connector version increment check | β |
QA checks | β |
π View the logs here
βοΈ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-s3 test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
source-s3 test report (commit
|
Step | Result |
---|---|
Connector package install | β |
Build source-s3 docker image for platform linux/x86_64 | β |
Unit tests | β |
Acceptance tests | β |
Code format checks | β |
Validate airbyte-integrations/connectors/source-s3/metadata.yaml | β |
Connector version semver check | β |
Connector version increment check | β |
QA checks | β |
π View the logs here
βοΈ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-s3 test
source-s3 test report (commit
|
Step | Result |
---|---|
Connector package install | β |
Build source-s3 docker image for platform linux/x86_64 | β |
Unit tests | β |
Acceptance tests | β |
Code format checks | β |
Validate airbyte-integrations/connectors/source-s3/metadata.yaml | β |
Connector version semver check | β |
Connector version increment check | β |
QA checks | β |
π View the logs here
βοΈ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-s3 test
What
Follow-up to #30453 to address #30353
How
Update legacy config transformer, tests and document breaking change.
π¨ User Impact π¨
As mentioned in the documentation, this change is only breaking if the user created S3 sources using the API and did not provide
streams.*.format
.