Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Facebook Marketing - add new fields to campaigns stream #30485

Merged

Conversation

midavadim
Copy link
Collaborator

@midavadim midavadim commented Sep 15, 2023

What

add new fields to campaigns stream

How

add 'status' & 'configured_status' fields

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

No breaking changes - added new fields to schema

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Sep 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@midavadim midavadim linked an issue Sep 15, 2023 that may be closed by this pull request
@midavadim midavadim changed the title 🎉 Source Facebook Marketing - add new fields to for campaigns stream 🎉 Source Facebook Marketing - add new fields to campaigns stream Sep 15, 2023
@github-actions
Copy link
Contributor

source-facebook-marketing test report (commit dd8121d895) - ✅

⏲️ Total pipeline duration: 80mn13s

Step Result
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@midavadim midavadim enabled auto-merge (squash) September 15, 2023 18:03
@github-actions
Copy link
Contributor

source-facebook-marketing test report (commit 6adde1c93d) - ✅

⏲️ Total pipeline duration: 94mn12s

Step Result
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@github-actions
Copy link
Contributor

source-facebook-marketing test report (commit af57fbb52e) - ✅

⏲️ Total pipeline duration: 91mn39s

Step Result
Connector package install
Build source-facebook-marketing docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@midavadim midavadim merged commit fcb9553 into master Sep 15, 2023
22 of 24 checks passed
@midavadim midavadim deleted the midavadim/27847-source-facebook-marketing-schema-update branch September 15, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Facebook Marketing: update campaigns schema
3 participants